-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-6067][SQL]delete the file with the same name before create the path for HiveFileFormatUtils.getHiveRecordWriter #4980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think this patch should test by the Reporter of SPARK-6067 |
|
ok to test |
|
/cc @liancheng |
|
Test build #29636 has finished for PR 4980 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe check for part- before getting a file system or checking if the file exists. This saves RPCs.
Did you mean > 0 in the sense of contains? that's not quite correct if so, since the condition should be >= 0. But then contains would be simpler anyway.
Finally, duplicat -> duplicate
|
thank you @srowen |
|
Test build #30804 has finished for PR 4980 at commit
|
|
Test build #31055 has started for PR 4980 at commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @srowen mentioned, please check "part-" first, and then check existence, to save NameNode RPC.
|
Test build #31228 has finished for PR 4980 at commit
|
|
can this patch be merged?:) |
|
@liancheng can this patch be merged? Is it still relevant? |
|
hi @andrewor14 @liancheng , I think this is a useful patch :) |
|
Seems that this issue has already fixed by #6833? |
|
Shall we close this PR then? |
|
no problem. close it :) @andrewor14 @liancheng |
this is commit for https://issues.apache.org/jira/browse/SPARK-6067