Skip to content

[SPARK-6458][SQL] Better error messages for invalid data sources #5158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marmbrus wants to merge 2 commits into from
Closed

[SPARK-6458][SQL] Better error messages for invalid data sources #5158

marmbrus wants to merge 2 commits into from

Conversation

@marmbrus
Copy link
Contributor

@marmbrus marmbrus commented Mar 24, 2015

Avoid unclear match errors and use AnalysisException.

@SparkQA
Copy link

SparkQA commented Mar 24, 2015

Test build #29061 has finished for PR 5158 at commit 90c6ba4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

yhuai
yhuai reviewed Mar 24, 2015
View reviewed changes
sql/core/src/main/scala/org/apache/spark/sql/sources/ddl.scala Outdated
Copy link
Contributor

@yhuai yhuai Mar 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: ${clazz.getCanonicalName} => $className

@yhuai
Copy link
Contributor

yhuai commented Mar 24, 2015

LGMT (just a minor comment)

@SparkQA
Copy link

SparkQA commented Mar 24, 2015

Test build #29099 has finished for PR 5158 at commit af9f82a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Mar 24, 2015
@marmbrus
[SPARK-6458][SQL] Better error messages for invalid data sources
f48c16d 
Avoid unclear match errors and use `AnalysisException`.

Author: Michael Armbrust <michael@databricks.com>

Closes #5158 from marmbrus/dataSourceError and squashes the following commits:

af9f82a [Michael Armbrust] Yins comment
90c6ba4 [Michael Armbrust] Better error messages for invalid data sources

(cherry picked from commit a8f51b8)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@asfgit asfgit closed this in a8f51b8 Mar 24, 2015
@marmbrus marmbrus deleted the dataSourceError branch August 3, 2015 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marmbrus @SparkQA @yhuai