Skip to content

[SPARK-6463][SQL] AttributeSet.equal should compare size #5194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marmbrus wants to merge 3 commits into from
Closed

[SPARK-6463][SQL] AttributeSet.equal should compare size #5194

marmbrus wants to merge 3 commits into from

Conversation

@marmbrus
Copy link
Contributor

@marmbrus marmbrus commented Mar 26, 2015

Previously this could result in sets compare equals when in fact the right was a subset of the left.

Based on #5133 by @sisihj

@marmbrus marmbrus mentioned this pull request Mar 26, 2015
Closed
@SparkQA
Copy link

SparkQA commented Mar 26, 2015

Test build #29193 has finished for PR 5194 at commit d4cbbc0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Data(weight: Double, mu: Vector, sigma: Matrix)

asfgit pushed a commit that referenced this pull request Mar 26, 2015
@marmbrus
[SPARK-6463][SQL] AttributeSet.equal should compare size
9edb34f 
Previously this could result in sets compare equals when in fact the right was a subset of the left.

Based on #5133 by sisihj

Author: sisihj <jun.hejun@huawei.com>
Author: Michael Armbrust <michael@databricks.com>

Closes #5194 from marmbrus/pr/5133 and squashes the following commits:

5ed4615 [Michael Armbrust] fix imports
d4cbbc0 [Michael Armbrust] Add test cases
0a0834f [sisihj]  AttributeSet.equal should compare size

(cherry picked from commit 276ef1c)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@asfgit asfgit closed this in 276ef1c Mar 26, 2015
@SparkQA
Copy link

SparkQA commented Mar 26, 2015

Test build #29196 has finished for PR 5194 at commit 5ed4615.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Data(weight: Double, mu: Vector, sigma: Matrix)

@marmbrus marmbrus deleted the pr/5133 branch August 3, 2015 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marmbrus @SparkQA