[SPARK-53856][CORE] Remove blacklist alternative config names
#52558
+17
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
commented
Oct 9, 2025
| DeprecatedConfig("spark.rpc", "2.0", "Not used anymore."), | ||
| DeprecatedConfig("spark.scheduler.executorTaskBlacklistTime", "2.1.0", | ||
| "Please use the new excludedOnFailure options, spark.excludeOnFailure.*"), | ||
| "Not used anymore. Please use the new excludedOnFailure options, spark.excludeOnFailure.*"), |
Member
Author
There was a problem hiding this comment.
We still maintain the revised deprecation warning message to lead a new configuration name.
Member
There was a problem hiding this comment.
So although users cannot use these configs after this PR, they will still be presented with the deprecation warning messages leading to new configs, right?
Member
Author
|
WDYT, @tgravescs , @cloud-fan , @HyukjinKwon , @zhengruifeng , @viirya , @mridulm , @LuciferYang , @yaooqinn , @huaxingao , @sarutak , @peter-toth ? |
peter-toth
approved these changes
Oct 9, 2025
Contributor
peter-toth
left a comment
peter-toth
left a comment
There was a problem hiding this comment.
I'm ok with this change.
sarutak
approved these changes
Oct 9, 2025
Member
sarutak
left a comment
sarutak
left a comment
There was a problem hiding this comment.
+1, I agree with this change too.
HyukjinKwon
approved these changes
Oct 10, 2025
yaooqinn
approved these changes
Oct 10, 2025
LuciferYang
approved these changes
Oct 10, 2025
huaxingao
approved these changes
Oct 10, 2025
Member
|
Merged to master, thank you @dongjoon-hyun and all. |
Member
Author
|
Thank you so much, @peter-toth , @sarutak , @viirya , @HyukjinKwon , @yaooqinn , @LuciferYang , @huaxingao , @beliefer ! |
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
### What changes were proposed in this pull request? This PR aims to remove `blacklist` alternative config names at Apache Spark 4.1.0 while keeping the revised deprecation warning messages. ### Why are the changes needed? At Apache Spark 2.1.0, `blacklist` configurations were added. - apache#15249 At Apache Spark 3.1.0, we renamed the blacklist features roughly from `*.blacklist.*` to `*.excludeOnFailure.*`. - apache#29906 At Apache Spark 4.1.0, this PR aims to complete the removal process at Apache Spark 4.x. Note that we didn't remove these at Spark 4 in order to reduce the hurdle from 3.x to 4.x in this configuration name layer. ### Does this PR introduce _any_ user-facing change? Yes if someone still uses `*.blacklist.*` configurations. However, Apache Spark deprecated and has been warning these configurations since 3.1.0 (March 2, 2021). It's highly unlikely. ### How was this patch tested? Manual review. **BEFORE** ``` $ git grep withAlternative | grep -i blacklist | wc -l 13 ``` **AFTER** ``` $ git grep withAlternative | grep -i blacklist | wc -l 0 ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52558 from dongjoon-hyun/SPARK-53856. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Kent Yao <yao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to remove
blacklistalternative config names at Apache Spark 4.1.0 while keeping the revised deprecation warning messages.Why are the changes needed?
At Apache Spark 2.1.0,
blacklistconfigurations were added.At Apache Spark 3.1.0, we renamed the blacklist features roughly from
*.blacklist.*to*.excludeOnFailure.*.At Apache Spark 4.1.0, this PR aims to complete the removal process at Apache Spark 4.x. Note that we didn't remove these at Spark 4 in order to reduce the hurdle from 3.x to 4.x in this configuration name layer.
Does this PR introduce any user-facing change?
Yes if someone still uses
*.blacklist.*configurations. However, Apache Spark deprecated and has been warning these configurations since 3.1.0 (March 2, 2021). It's highly unlikely.How was this patch tested?
Manual review.
BEFORE
AFTER
Was this patch authored or co-authored using generative AI tooling?
No.