[SPARK-54040][BUILD] Remove unused commons-collections 3.x #52743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
Oct 27, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Nice clean-up! Thank you, @pan3793 .
Merged to master for Apache Spark 4.1.0.
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
### What changes were proposed in this pull request? The latest commons-collections 3.x was published in Nov 2015, which is pretty old, it was added back to Spark dep list in SPARK-38696, due to Hadoop transitive usage. HADOOP-15760 (fixed in 3.4.2, 3.5.0) totally removes usage of it, so it's safe to remove it from Spark now. ### Why are the changes needed? Remove useud dependency. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GHA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52743 from pan3793/SPARK-54040. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 18, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 18, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 18, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 18, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 18, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 18, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 18, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 18, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 18, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 18, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 18, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 18, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 19, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 21, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 22, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 22, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 22, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 22, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 23, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 23, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 23, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 23, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 23, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 24, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 25, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 25, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Dec 29, 2025
This was referenced Dec 29, 2025
baibaichen
added a commit
to apache/incubator-gluten
that referenced
this pull request
Dec 30, 2025
…ark 4.1 (#11313) * [Fix] Remove `@NotNull` annotations to resolve dependency issues caused by ORC upgrade. apache/spark#51676 * [Fix] Make `reserveNewColumn` public in `ArrowWritableColumnVector` and `WritableColumnVectorShim` In Java, an overriding method's access modifier cannot be more restrictive than the overridden method. Changing from protected to public is safe and ensures compatibility before the Spark version upgrade. see apache/spark#52557 * [Fix] Add GeographyVal and GeometryVal support in ArrowColumnarRow, BatchCarrierRow and ColumnarToCarrierRowExecBase see [SPIP: Add geospatial types in Spark](https://issues.apache.org/jira/browse/SPARK-51658) * [Fix] Update commons-collections to version 4.5.0. see apache/spark#52743 * [Fix] Enable SPARK_TESTING environment variable for Spark test jobs see apache/spark#53344
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The latest commons-collections 3.x was published in Nov 2015, which is pretty old, it was added back to Spark dep list in SPARK-38696, due to Hadoop transitive usage.
HADOOP-15760 (fixed in 3.4.2, 3.5.0) totally removes usage of it, so it's safe to remove it from Spark now.
Why are the changes needed?
Remove useud dependency.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GHA.
Was this patch authored or co-authored using generative AI tooling?
No.