[SPARK-55519][SQL][TESTS] Fix V2FunctionBenchmark#54540
Closed
pan3793 wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-55519][SQL][TESTS] Fix V2FunctionBenchmark#54540pan3793 wants to merge 3 commits intoapache:masterfrom
pan3793 wants to merge 3 commits intoapache:masterfrom
Conversation
Member
There was a problem hiding this comment.
Actually, there is a JIRA issue, SPARK-55519 already for this, @pan3793 . Could you use that by change the PR title and close the JIRA issue, SPARK-55744, because we prefer to use the smaller JIRA IDs for duplications?
It's reported here.
Member
Author
|
@dongjoon-hyun thanks for the information, was not aware of that, let me use that and close SPARK-55744 as duplicated |
dongjoon-hyun
approved these changes
Feb 27, 2026
Member
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @pan3793 .
…tionBenchmark (JDK 21, Scala 2.13, split 1 of 1)
…tionBenchmark (JDK 17, Scala 2.13, split 1 of 1)
Member
Author
|
Benchmark results for JDK 17 and 21 are updated, and they look reasonable. @dongjoon-hyun, could you please double-check too? JDK 25 benchmark results will be uploaded in bulk later, via an independent PR. |
Member
|
All results look correct to me. Thank you, @pan3793 . Merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix V2FunctionBenchmark, caused by SPARK-53968 (#52681)
Why are the changes needed?
Fix the benchmark.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Verified locally, GHA benchmark reports for JDK 17 and 21 are updated.
Was this patch authored or co-authored using generative AI tooling?
No.