Skip to content

Conversation

@srowen
Copy link
Member

@srowen srowen commented Jul 31, 2015

Update to shade plugin 2.4.1, which removes the need for the dependency-reduced-POM workaround and the 'release' profile. Fix management of shade plugin version so children inherit it; bump assembly plugin version while here

See https://issues.apache.org/jira/browse/SPARK-8819

I verified that mvn clean package -DskipTests works with Maven 3.3.3.

@pwendell are you up for trying this for the 1.5.0 release?

…cy-reduced-POM workaround and the 'release' profile. Fix management of shade plugin version so children inherit it; bump assembly plugin version while here
@SparkQA
Copy link

SparkQA commented Jul 31, 2015

Test build #39211 has finished for PR 7826 at commit e0b0fd2.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin
Copy link
Contributor

vanzin commented Jul 31, 2015

LGTM, I'd prefer if this was in the release.

@SparkQA
Copy link

SparkQA commented Jul 31, 2015

Test build #1256 has finished for PR 7826 at commit e0b0fd2.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class MulticlassClassificationEvaluator (override val uid: String)
    • class NaiveBayes(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPredictionCol):
    • class NaiveBayesModel(JavaModel):
    • class MulticlassClassificationEvaluator(JavaEvaluator, HasLabelCol, HasPredictionCol):

@srowen
Copy link
Member Author

srowen commented Jul 31, 2015

Really can't be due to this change, but let me try it again

@pwendell
Copy link
Contributor

Yeah seems like a good idea - LGTM

@SparkQA
Copy link

SparkQA commented Jul 31, 2015

Test build #1259 has finished for PR 7826 at commit e0b0fd2.

  • This patch passes all tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member Author

srowen commented Jul 31, 2015

Since it passes tests as expected, and does appear to merge according to Github, I'm ignoring that "does not merge cleanly" and merging to master. I'll try to back-port to 1.4 and 1.3 since that's where SPARK-8819 was merged.

asfgit pushed a commit that referenced this pull request Jul 31, 2015
…e plugin is updated

Update to shade plugin 2.4.1, which removes the need for the dependency-reduced-POM workaround and the 'release' profile. Fix management of shade plugin version so children inherit it; bump assembly plugin version while here

See https://issues.apache.org/jira/browse/SPARK-8819

I verified that `mvn clean package -DskipTests` works with Maven 3.3.3.

pwendell are you up for trying this for the 1.5.0 release?

Author: Sean Owen <sowen@cloudera.com>

Closes #7826 from srowen/SPARK-9507 and squashes the following commits:

e0b0fd2 [Sean Owen] Update to shade plugin 2.4.1, which removes the need for the dependency-reduced-POM workaround and the 'release' profile. Fix management of shade plugin version so children inherit it; bump assembly plugin version while here

(cherry picked from commit 6e5fd61)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@asfgit asfgit closed this in 6e5fd61 Jul 31, 2015
asfgit pushed a commit that referenced this pull request Jul 31, 2015
…e plugin is updated

Update to shade plugin 2.4.1, which removes the need for the dependency-reduced-POM workaround and the 'release' profile. Fix management of shade plugin version so children inherit it; bump assembly plugin version while here

See https://issues.apache.org/jira/browse/SPARK-8819

I verified that `mvn clean package -DskipTests` works with Maven 3.3.3.

pwendell are you up for trying this for the 1.5.0 release?

Author: Sean Owen <sowen@cloudera.com>

Closes #7826 from srowen/SPARK-9507 and squashes the following commits:

e0b0fd2 [Sean Owen] Update to shade plugin 2.4.1, which removes the need for the dependency-reduced-POM workaround and the 'release' profile. Fix management of shade plugin version so children inherit it; bump assembly plugin version while here

(cherry picked from commit 6e5fd61)
Signed-off-by: Sean Owen <sowen@cloudera.com>

# Conflicts:
#	dev/create-release/create-release.sh
#	pom.xml
@srowen srowen deleted the SPARK-9507 branch July 31, 2015 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants