-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-9507] [BUILD] Remove dependency reduced POM hack now that shade plugin is updated #7826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…cy-reduced-POM workaround and the 'release' profile. Fix management of shade plugin version so children inherit it; bump assembly plugin version while here
|
Test build #39211 has finished for PR 7826 at commit
|
|
LGTM, I'd prefer if this was in the release. |
|
Test build #1256 has finished for PR 7826 at commit
|
|
Really can't be due to this change, but let me try it again |
|
Yeah seems like a good idea - LGTM |
|
Test build #1259 has finished for PR 7826 at commit
|
|
Since it passes tests as expected, and does appear to merge according to Github, I'm ignoring that "does not merge cleanly" and merging to master. I'll try to back-port to 1.4 and 1.3 since that's where SPARK-8819 was merged. |
…e plugin is updated Update to shade plugin 2.4.1, which removes the need for the dependency-reduced-POM workaround and the 'release' profile. Fix management of shade plugin version so children inherit it; bump assembly plugin version while here See https://issues.apache.org/jira/browse/SPARK-8819 I verified that `mvn clean package -DskipTests` works with Maven 3.3.3. pwendell are you up for trying this for the 1.5.0 release? Author: Sean Owen <sowen@cloudera.com> Closes #7826 from srowen/SPARK-9507 and squashes the following commits: e0b0fd2 [Sean Owen] Update to shade plugin 2.4.1, which removes the need for the dependency-reduced-POM workaround and the 'release' profile. Fix management of shade plugin version so children inherit it; bump assembly plugin version while here (cherry picked from commit 6e5fd61) Signed-off-by: Sean Owen <sowen@cloudera.com>
…e plugin is updated Update to shade plugin 2.4.1, which removes the need for the dependency-reduced-POM workaround and the 'release' profile. Fix management of shade plugin version so children inherit it; bump assembly plugin version while here See https://issues.apache.org/jira/browse/SPARK-8819 I verified that `mvn clean package -DskipTests` works with Maven 3.3.3. pwendell are you up for trying this for the 1.5.0 release? Author: Sean Owen <sowen@cloudera.com> Closes #7826 from srowen/SPARK-9507 and squashes the following commits: e0b0fd2 [Sean Owen] Update to shade plugin 2.4.1, which removes the need for the dependency-reduced-POM workaround and the 'release' profile. Fix management of shade plugin version so children inherit it; bump assembly plugin version while here (cherry picked from commit 6e5fd61) Signed-off-by: Sean Owen <sowen@cloudera.com> # Conflicts: # dev/create-release/create-release.sh # pom.xml
Update to shade plugin 2.4.1, which removes the need for the dependency-reduced-POM workaround and the 'release' profile. Fix management of shade plugin version so children inherit it; bump assembly plugin version while here
See https://issues.apache.org/jira/browse/SPARK-8819
I verified that
mvn clean package -DskipTestsworks with Maven 3.3.3.@pwendell are you up for trying this for the 1.5.0 release?