Skip to content

Conversation

@liancheng
Copy link
Contributor

This is a fork of PR #7191 authored by @steveloughran. This PR fixes HiveSparkSubmitSuite test failures.

Hive 0.14.0+ adds time suffixes (s, ms, and d, etc.) to the original default values of a bunch of HiveConf options that define various timeouts (see HIVE-5799). This fails HiveContext initialization when we are connecting to a lower version of Hive (e.g., 0.12.0 in HiveSparkSubmitSuite), because these options are expected to be integral values in lower versions of Hive.

This PR enumerates all such options and converts their values to corresponding Long values according to their output time unit before passing them to the metastore Hive client of lower versions.

Please refer to this failed Jenkins build for more details about the failed test case.

…ts pass instead of timing out: undetected regression?
…essages to say "w/Hive 1.2.1" in console output
…in the raised exception; this ensures that the stdout/stderr is included in jenkins reports, so it becomes possible to diagnose the cause.
…e rest of the work; can be backported to earlier versions
…ure that jersey server is on classpath on hadoop versions < 2.6
…till no obvious reason why jersey server code in spark-assembly isn't being picked up -it hasn't been shaded
steveloughran and others added 21 commits August 1, 2015 10:06
…nings. It's all autogenerated code, so still ugly.
-things that aren't needed are excluded
-sql/hive built with ivy is in sync with the maven reconciliation policy, rather than latest-first
…ed references in the hive- packages; this keeps mvn and ivy resolution compatible, as the reconciliation policy is "by hand"
… This one has the protobuf-shaded hive-exec jar
@liancheng
Copy link
Contributor Author

Enumerating all time ConfVars looks a little bit awkward, but I couldn't figure out a smarter way :(

@liancheng liancheng force-pushed the hive-1.2.1/hiveconf-timevar-fix branch from e4556c1 to 6a92bb0 Compare August 2, 2015 15:49
@liancheng
Copy link
Contributor Author

@steveloughran Changing default values of these ConfVars breaks backwards-compatibility. Is it worth a Hive JIRA ticket?

@SparkQA
Copy link

SparkQA commented Aug 2, 2015

Test build #39427 has finished for PR 7868 at commit e4556c1.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 2, 2015

Test build #39428 has finished for PR 7868 at commit 6a92bb0.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@liancheng
Copy link
Contributor Author

Closing this since it's merged into PR #7191.

@liancheng liancheng closed this Aug 3, 2015
@liancheng liancheng deleted the hive-1.2.1/hiveconf-timevar-fix branch August 3, 2015 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants