Skip to content

Conversation

@yanboliang
Copy link
Contributor

Add Python API, user guide and example for ml.feature.ElementwiseProduct.

@yanboliang
Copy link
Contributor Author

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Aug 9, 2015

Test build #40270 has finished for PR 8061 at commit 48239ab.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class ElementwiseProduct(JavaTransformer, HasInputCol, HasOutputCol):

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: indent to match parenthesis, as in PySpark internal code

@jkbradley
Copy link
Member

Thanks for the PR! Just small comments.

@SparkQA
Copy link

SparkQA commented Aug 12, 2015

Test build #40628 has finished for PR 8061 at commit 2ff657f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class ElementwiseProduct(JavaTransformer, HasInputCol, HasOutputCol):

@yanboliang
Copy link
Contributor Author

Jenkins, test this please.

@jkbradley
Copy link
Member

LGTM once merge conflicts are fixed and tests pass

@SparkQA
Copy link

SparkQA commented Aug 13, 2015

Test build #40713 timed out for PR 8061 at commit 5c87ec3 after a configured wait of 175m.

@SparkQA
Copy link

SparkQA commented Aug 13, 2015

Test build #40738 has finished for PR 8061 at commit d31ed8a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • trait Identifiable
    • class VectorUDT extends UserDefinedType[Vector]
    • class ElementwiseProduct(JavaTransformer, HasInputCol, HasOutputCol):

@jkbradley
Copy link
Member

New though: I'm going to quickly test to see if the scalingVec can be set as a numpy or Python array. If that works, then I'll merge it. Otherwise, it'll be nice to add.

@jkbradley
Copy link
Member

Actually, thinking more about it, that should be handled in the wrapper (_transfer_params_to_java) and might take too long to do. Would you mind noting in the built-in Param doc for scalingVec that it must be an MLlib Vector type? After that, this should be ready.

@SparkQA
Copy link

SparkQA commented Aug 15, 2015

Test build #40947 has finished for PR 8061 at commit 1dd6224.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class ElementwiseProduct(JavaTransformer, HasInputCol, HasOutputCol):

@yanboliang
Copy link
Contributor Author

@jkbradley I have updated Param doc. I opened SPARK-10009 to track the issue of supporting Param of Vector type can be set with Python array or numpy.array. I think we can resolve it in the next release cycle.

@jkbradley
Copy link
Member

test this please

@jkbradley
Copy link
Member

just testing once more, then will merge

@SparkQA
Copy link

SparkQA commented Aug 18, 2015

Test build #41072 has finished for PR 8061 at commit 1dd6224.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class ElementwiseProduct(JavaTransformer, HasInputCol, HasOutputCol):

@jkbradley
Copy link
Member

Merging with master and branch-1.5

asfgit pushed a commit that referenced this pull request Aug 18, 2015
…ure.ElementwiseProduct

Add Python API, user guide and example for ml.feature.ElementwiseProduct.

Author: Yanbo Liang <ybliang8@gmail.com>

Closes #8061 from yanboliang/SPARK-9768.

(cherry picked from commit 0076e82)
Signed-off-by: Joseph K. Bradley <joseph@databricks.com>
@asfgit asfgit closed this in 0076e82 Aug 18, 2015
@yanboliang yanboliang deleted the SPARK-9768 branch August 26, 2015 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants