Skip to content

[SPARK-10076] [ML] make MultilayerPerceptronClassifier layers and weights public #8263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yanboliang wants to merge 1 commit into from
Closed

[SPARK-10076] [ML] make MultilayerPerceptronClassifier layers and weights public #8263

yanboliang wants to merge 1 commit into from

Conversation

@yanboliang
Copy link
Contributor

@yanboliang yanboliang commented Aug 18, 2015

Fix the issue that layers and weights should be public variables of MultilayerPerceptronClassificationModel. Users can not get layers and weights from a MultilayerPerceptronClassificationModel currently.

@yanboliang yanboliang mentioned this pull request Aug 18, 2015
Closed
@mengxr
Copy link
Contributor

mengxr commented Aug 18, 2015

This changes public API. Could you make a JIRA as well?

@yanboliang yanboliang changed the title [ML] makes MultilayerPerceptronClassifier layers and weights public [SPARK-10076] [ML] make MultilayerPerceptronClassifier layers and weights public Aug 18, 2015
@yanboliang
Copy link
Contributor Author

yanboliang commented Aug 18, 2015

@mengxr SPARK-10076

@mengxr
Copy link
Contributor

mengxr commented Aug 18, 2015

LGTM pending Jenkins.

@SparkQA
Copy link

SparkQA commented Aug 18, 2015

Test build #41087 has finished for PR 8263 at commit 7431251.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class ElementwiseProduct(JavaTransformer, HasInputCol, HasOutputCol):

asfgit pushed a commit that referenced this pull request Aug 18, 2015
@yanboliang @mengxr
[SPARK-10076] [ML] make MultilayerPerceptronClassifier layers and wei…
40b89c3 
…ghts public

Fix the issue that ```layers``` and ```weights``` should be public variables of ```MultilayerPerceptronClassificationModel```. Users can not get ```layers``` and ```weights``` from a ```MultilayerPerceptronClassificationModel``` currently.

Author: Yanbo Liang <ybliang8@gmail.com>

Closes #8263 from yanboliang/mlp-public.

(cherry picked from commit dd0614f)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@mengxr
Copy link
Contributor

mengxr commented Aug 18, 2015

Merged into master and branch-1.5. Thanks!

@asfgit asfgit closed this in dd0614f Aug 18, 2015
@yanboliang yanboliang deleted the mlp-public branch August 26, 2015 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yanboliang @mengxr @SparkQA