[SPARK-8400] [ML] Added check in ml.ALS for positive block size parameter setting #8363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…auto-config is not supported
BryanCutler
changed the title
Member
|
Seems fine to me. |
|
Test build #1680 timed out for PR 8363 at commit |
|
Test build #1683 has finished for PR 8363 at commit
|
Member
Author
|
Not sure why the last test failed, maybe retest once more? cc @mengxr |
|
Test build #1690 timed out for PR 8363 at commit |
|
Test build #1691 has finished for PR 8363 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Aug 25, 2015
…eter setting Added check for positive block size with a note that -1 for auto-configuring is not supported Author: Bryan Cutler <bjcutler@us.ibm.com> Closes #8363 from BryanCutler/ml.ALS-neg-blocksize-8400-1.3.
Contributor
|
Can we close this PR since it's merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check for positive block size with a note that -1 for auto-configuring is not supported