-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-11835] Adds a sidebar menu to MLlib's documentation #9826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #46280 has finished for PR 9826 at commit
|
docs/_data/menu-ml.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
elastic-net
|
@mengxr with the fixes, the top menu breaks before the side menu :-) |
|
This is about as much as I can do with my very limited knowledge of CSS, so additional fixes can be done in a separate PR. |
|
Test build #46343 has finished for PR 9826 at commit
|
|
nice! I wonder if there's something more general we can do. This is useful across all pages in the docs so it would be worth investigating if there are existing frameworks we can use. E.g. this format is nice: http://docs.scala-lang.org/overviews/core/futures.html |
|
@andrewor14 this is a different issue: the SIPs show the table of contents within one document, which we already have with the |
|
@mengxr based on our discussions, here is a slightly updated version:
|
|
@thunterdb Could you try the following CSS: .left-menu-wrapper {
position: absolute;
height: 100%;
width: 256px;
margin-top: -20px;
padding-top: 20px;
background-color: #F0F8FC;
}
.left-menu {
position: fixed;
width: 256px;
padding-right: 10px;
}It doesn't fix the issue with hiding the sidebar but makes the background lighter: |
|
@mengxr comment addressed |
|
test this please |
2 similar comments
|
test this please |
|
test this please |
|
Test build #46457 has finished for PR 9826 at commit
|
This PR adds a sidebar menu when browsing the user guide of MLlib. It uses a YAML file to describe the structure of the documentation. It should be trivial to adapt this to the other projects.  Author: Timothy Hunter <timhunter@databricks.com> Closes #9826 from thunterdb/spark-11835. (cherry picked from commit fc4b792) Signed-off-by: Xiangrui Meng <meng@databricks.com>
|
LGTM. Merged into master and branch-1.6. Thanks! (The Jenkins test failure is irrelevant. The PR build doesn't compile doc anyway. So I verified the changes on my local computer.) |





This PR adds a sidebar menu when browsing the user guide of MLlib. It uses a YAML file to describe the structure of the documentation. It should be trivial to adapt this to the other projects.