Skip to content

[SPARK-11871] Add save/load for MLPC #9854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yinxusen wants to merge 8 commits into from
Closed

[SPARK-11871] Add save/load for MLPC #9854

yinxusen wants to merge 8 commits into from

Conversation

@yinxusen
Copy link
Contributor

@yinxusen yinxusen commented Nov 20, 2015

What changes were proposed in this pull request?

https://issues.apache.org/jira/browse/SPARK-11871

Add save/load for MLPC

How was this patch tested?

Test with Scala unit test

@SparkQA
Copy link

SparkQA commented Nov 20, 2015

Test build #46389 has finished for PR 9854 at commit 949db73.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * class MultilayerPerceptronClassificationModelWriter(\n

@yinxusen yinxusen mentioned this pull request Nov 21, 2015
Closed
@yinxusen
Copy link
Contributor Author

yinxusen commented Nov 21, 2015

Pls ignore my first comment, I have splited the test of model and classifier separately.

@SparkQA
Copy link

SparkQA commented Nov 21, 2015

Test build #46478 has finished for PR 9854 at commit 881428f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * class MultilayerPerceptronClassificationModelWriter(\n

@SparkQA
Copy link

SparkQA commented Nov 24, 2015

Test build #46606 has finished for PR 9854 at commit 5b852cd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * class MultilayerPerceptronClassificationModelWriter(\n

@mengxr
Copy link
Contributor

mengxr commented Nov 24, 2015

cc @avulanov

@avulanov
Copy link
Contributor

avulanov commented Nov 24, 2015

LGTM

@yinxusen
Copy link
Contributor Author

yinxusen commented Jan 7, 2016

@mengxr @jkbradley I change the version code. Does it looks good to you?

@SparkQA
Copy link

SparkQA commented Jan 7, 2016

Test build #48935 has finished for PR 9854 at commit d0e517f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

jkbradley commented Mar 9, 2016

I'll take a look now!

@jkbradley
Copy link
Member

jkbradley commented Mar 9, 2016

In the meantime, could you please update the description (to be a reasonable commit message)? Thanks

@SparkQA
Copy link

SparkQA commented Mar 9, 2016

Test build #2624 has finished for PR 9854 at commit d0e517f.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

jkbradley
jkbradley reviewed Mar 9, 2016
View reviewed changes
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
sqlContext.createDataFrame(Seq(data)).repartition(1).write.parquet(dataPath)
}
}
private class MultilayerPerceptronClassificationModelReader
Copy link
Member

@jkbradley jkbradley Mar 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline

@jkbradley
Copy link
Member

jkbradley commented Mar 9, 2016

The style issue & those little comments are the only items I see. Thanks!

@yinxusen
Copy link
Contributor Author

yinxusen commented Mar 10, 2016

test it please

@SparkQA
Copy link

SparkQA commented Mar 10, 2016

Test build #52802 has finished for PR 9854 at commit 9352e77.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yinxusen
Copy link
Contributor Author

yinxusen commented Mar 10, 2016

test it please

@SparkQA
Copy link

SparkQA commented Mar 10, 2016

Test build #52804 has finished for PR 9854 at commit 68570e9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yinxusen
Copy link
Contributor Author

yinxusen commented Mar 10, 2016

@jkbradley Fixed.

@yinxusen
Copy link
Contributor Author

yinxusen commented Mar 24, 2016

@jkbradley Is this looking good now?

@mengxr
Copy link
Contributor

mengxr commented Mar 24, 2016

test this please

@SparkQA
Copy link

SparkQA commented Mar 24, 2016

Test build #54091 has finished for PR 9854 at commit 68570e9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor

mengxr commented Mar 24, 2016

LGTM. Merged into master. Thanks!

@asfgit asfgit closed this in 2cf46d5 Mar 24, 2016
@yinxusen
Copy link
Contributor Author

yinxusen commented Mar 24, 2016

Thanks!

@yanboliang
Copy link
Contributor

yanboliang commented Mar 25, 2016

Send #11952 for Python API.

@avulanov avulanov mentioned this pull request Mar 28, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yinxusen @SparkQA @mengxr @avulanov @jkbradley @yanboliang