Requirement: Hide all 3 time related filters when there's no temporal columns in datasets that support charts on dashboard.
Please test with dashboard that has at least two datasets. 1) both don't have temporal columns, 2) only one has
Edge case: If a dashboard has charts created from dataset A(has temporal column) and charts created from dataset B (without temporal column), when user create a time range filter, charts created from dataset B should be unscoped in the scoping tree by default.
It appears that the COVID dataset doesn't have a temporal column. Which raises the question, we should probably not show a time filter (or time column filter for that matter) if there are no temporal columns available in the target dataset. However, this same problem applies to Filter Box as well, so I propose leaving that to a later PR.
Originally posted by @villebro in #15015 (comment)
Requirement: Hide all 3 time related filters when there's no temporal columns in datasets that support charts on dashboard.
Please test with dashboard that has at least two datasets. 1) both don't have temporal columns, 2) only one has
Edge case: If a dashboard has charts created from dataset A(has temporal column) and charts created from dataset B (without temporal column), when user create a time range filter, charts created from dataset B should be unscoped in the scoping tree by default.
It appears that the COVID dataset doesn't have a temporal column. Which raises the question, we should probably not show a time filter (or time column filter for that matter) if there are no temporal columns available in the target dataset. However, this same problem applies to Filter Box as well, so I propose leaving that to a later PR.
Originally posted by @villebro in #15015 (comment)