TableSelector handle error tests do not run correctly

[khtruong]

There are a few tests in spec/javascripts/components/TableSelector_spec.jsx that do not properly test promises: "fetchSchemas.should dispatch a danger toast on error" and "fetchTables.should dispatch a danger toast on error". These tests are not returning a promise and Jest just calls the promise and continues onto the next test. This causes false positives.

The fix is to return the promise in the test. But when the tests are updated to return a promise, there are more errors. This issues tracks fixing up these unit tests.

Expected results

Verifies the promise logic correctly.

Actual results

Tests call the promise and move on to the next test, giving a false positive.

How to reproduce the bug

1. Set breakpoints and "npm run test".
2. You will see that we are actually failing but the tests are green.

Environment

latest master

[issue-label-bot]

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.97. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.