Skip to content

fix(sqllab): table refresh API endpoint#10076

Merged
ktmud merged 1 commit into
apache:masterfrom
ktmud:select-bug
Jun 17, 2020
Merged

fix(sqllab): table refresh API endpoint#10076
ktmud merged 1 commit into
apache:masterfrom
ktmud:select-bug

Conversation

@ktmud
Copy link
Copy Markdown
Member

@ktmud ktmud commented Jun 16, 2020

SUMMARY

Fix #10072 URLs generated by SQL Lab for loading schemas and tables are busted.

The bug was introduced by #9628 because of the changed signature of the onChange handler for react-select. It doesn't really affect the end users except invalidated the schema & table refresh button here:

Snip20200616_35

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

cc @willbarrett

@ktmud ktmud changed the title bugfix(sqllab): table refresh API endpoint fix(sqllab): table refresh API endpoint Jun 17, 2020
@ktmud ktmud merged commit 5d4d50a into apache:master Jun 17, 2020
@ktmud ktmud deleted the select-bug branch June 17, 2020 19:24
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 First shipped in 0.37.0 labels Mar 12, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 0.37.0 First shipped in 0.37.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: URLs generated by SQL Lab for loading schemas and tables are busted

3 participants