Skip to content

fix: deckgl dimension select missing options#10277

Merged
ktmud merged 1 commit into
apache:masterfrom
ktmud:bugfix-deckgl
Jul 10, 2020
Merged

fix: deckgl dimension select missing options#10277
ktmud merged 1 commit into
apache:masterfrom
ktmud:bugfix-deckgl

Conversation

@ktmud
Copy link
Copy Markdown
Member

@ktmud ktmud commented Jul 9, 2020

SUMMARY

Fix Bug #10246 introduced by #9455 and #9628 .

Also moved color picker to its own row so to give more space for dimension select.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TEST PLAN

  • Manual testing
  • Go create a Deck.gl Arc or Deck.gl Scatter chart

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@ktmud ktmud requested review from kristw, rusackas and villebro July 9, 2020 23:53
@ktmud
Copy link
Copy Markdown
Member Author

ktmud commented Jul 9, 2020

cc @eugeniamz

Copy link
Copy Markdown
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@ktmud ktmud merged commit af864e9 into apache:master Jul 10, 2020
@ktmud ktmud deleted the bugfix-deckgl branch July 10, 2020 01:27
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@sashankpappu
Copy link
Copy Markdown

Still seeing the same issue . Can you let me know if we need to change anything ?

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 First shipped in 0.37.0 labels Mar 12, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v0.37 🚢 0.37.0 First shipped in 0.37.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants