chore: removing fsevents dependency#10751
Merged
Merged
Conversation
etr2460
reviewed
Sep 1, 2020
Member
etr2460
left a comment
etr2460
left a comment
There was a problem hiding this comment.
I wonder, did you test to make sure that jest watch still works with this gone? Perhaps uninstall fsevents globally with npm as well, just in case you've already got it on your system from something else
Member
|
By the way, i think having fsevents as a normal dep isn't the right thing to do, as it breaks non mac environments. I think removing the dep altogether should be fine |
etr2460
approved these changes
Sep 2, 2020
Member
Author
|
Ugh... what a troublesome package! Merging this for now. |
serenajiang
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Sep 2, 2020
amitmiran137
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Sep 7, 2020
…boards_permissions * upstream/master: (32 commits) docs: Add a note to contributing.md on reporting security vulnerabilities (apache#10796) Fix: Include RLS filters for cache keys (apache#10805) feat: filters for database list view (apache#10772) fix: MVC show saved query (apache#10781) added creator column and adjusted order columns (apache#10789) security: disallow uuid package on jinja2 (apache#10794) feat: CRUD REST API for saved queries (apache#10777) fix: disable domain sharding on explore view (apache#10787) fix: can not type `0.05` in `TextControl` (apache#10778) fix: pivot table timestamp grouping (apache#10774) fix: add validator information to email/slack alerts (apache#10762) More Label touchups (margins) (apache#10722) fix: dashboard extra filters (apache#10692) fix: re-installing local superset in cache image (apache#10766) feat: SIP-34 table list view for databases (apache#10705) refactor: convert DatasetList schema filter to use new distinct api (apache#10746) chore: removing fsevents dependency (apache#10751) Fix precommit hook for docs/installation.rst (apache#10759) feat(database): POST, PUT, DELETE API endpoints (apache#10741) docs: Update OAuth configuration in installation.rst (apache#10748) ...
villebro
pushed a commit
to preset-io/superset
that referenced
this pull request
Sep 11, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
In a prior PR, I moved this from an Optional Dependency to a Dependency, along with several other package changes, to get CI to start working again. Since this isn't used directly by superset (as far as I can see) I figured it's worth yanking it entirely now to see if CI still passes.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
🤞 CI
ADDITIONAL INFORMATION