Skip to content

docs: Fix typo in installing from scratch#11026

Merged
mistercrunch merged 1 commit into
apache:masterfrom
philipqnguyen:doc-installing-scratch-typo
Oct 22, 2020
Merged

docs: Fix typo in installing from scratch#11026
mistercrunch merged 1 commit into
apache:masterfrom
philipqnguyen:doc-installing-scratch-typo

Conversation

@philipqnguyen
Copy link
Copy Markdown
Contributor

Change "insode" to "inside".

Note:
Original PR was here #10985, but the CI seemed to continually be stuck even after multiple retries. So I'm trying again with a new PR and a new commit.

@nytai
Copy link
Copy Markdown
Member

nytai commented Sep 23, 2020

I'm still very confused about what's going on here, for some reason not all the checks are running

@philipqnguyen
Copy link
Copy Markdown
Contributor Author

Ya, I'm at a loss as well @nytai. I guess you could make your own PR with this change separately to see if that works?

@nytai
Copy link
Copy Markdown
Member

nytai commented Sep 23, 2020

Yeah I'll open a PR, this probably isn't worth spending more time on

@nytai
Copy link
Copy Markdown
Member

nytai commented Sep 23, 2020

Ah, looks like the same thing happened on my PR. Looks like it's this filter here https://github.com/preset-io/incubator-superset/blob/master/.github/workflows/superset-python.yml#L9

@philipqnguyen philipqnguyen force-pushed the doc-installing-scratch-typo branch from 327c710 to f6f448f Compare October 1, 2020 17:31
@nytai nytai closed this Oct 22, 2020
@nytai nytai reopened this Oct 22, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 22, 2020

Codecov Report

Merging #11026 into master will increase coverage by 8.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11026      +/-   ##
==========================================
+ Coverage   65.86%   73.92%   +8.05%     
==========================================
  Files         826      444     -382     
  Lines       38976    14890   -24086     
  Branches     3669     3654      -15     
==========================================
- Hits        25671    11007   -14664     
+ Misses      13195     3786    -9409     
+ Partials      110       97      -13     
Flag Coverage Δ
#cypress 56.07% <ø> (-0.50%) ⬇️
#javascript 62.63% <ø> (+0.42%) ⬆️
#python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uperset-frontend/src/components/ExpandableList.tsx 0.00% <0.00%> (-94.45%) ⬇️
...et-frontend/src/SqlLab/components/QueryHistory.jsx 50.00% <0.00%> (-33.34%) ⬇️
.../explore/components/controls/DatasourceControl.jsx 73.07% <0.00%> (-11.54%) ⬇️
.../src/explore/components/AdhocMetricEditPopover.jsx 69.86% <0.00%> (-10.91%) ⬇️
superset-frontend/src/SqlLab/components/App.jsx 69.23% <0.00%> (-8.55%) ⬇️
...src/SqlLab/components/ExploreCtasResultsButton.jsx 7.14% <0.00%> (-6.20%) ⬇️
...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx 50.00% <0.00%> (-6.00%) ⬇️
...rontend/src/visualizations/FilterBox/FilterBox.jsx 60.49% <0.00%> (-5.56%) ⬇️
superset-frontend/src/common/components/Tabs.tsx 96.00% <0.00%> (-4.00%) ⬇️
...ntend/src/explore/components/AdhocFilterOption.jsx 80.64% <0.00%> (-3.98%) ⬇️
... and 517 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a72082...f6f448f. Read the comment docs.

@mistercrunch mistercrunch merged commit a366a34 into apache:master Oct 22, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 First shipped in 1.0.0 labels Mar 12, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0 First shipped in 1.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants