Skip to content

feat(dashboard): fetch charts by owners instead of created_by#11336

Merged
nytai merged 1 commit into
apache:masterfrom
preset-io:tai/fetch-charts-by-owners
Oct 24, 2020
Merged

feat(dashboard): fetch charts by owners instead of created_by#11336
nytai merged 1 commit into
apache:masterfrom
preset-io:tai/fetch-charts-by-owners

Conversation

@nytai
Copy link
Copy Markdown
Member

@nytai nytai commented Oct 20, 2020

SUMMARY

The charts tab in the dashboard edit pane fetches from /sliceasync/api/read?_flt_0_created_by=2 which are charts the user created. This updates switches over to using the new api endpoint for charts and fetches charts the user owns.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

  • Navigate to the charts tab in the dashboard edit pane.
  • The tab should now be populated with charts the user owns.
  • Nothing else should have changed.

ADDITIONAL INFORMATION

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 20, 2020

Codecov Report

Merging #11336 into master will increase coverage by 4.10%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11336      +/-   ##
==========================================
+ Coverage   61.56%   65.67%   +4.10%     
==========================================
  Files         835      835              
  Lines       39653    39658       +5     
  Branches     3604     3606       +2     
==========================================
+ Hits        24414    26045    +1631     
+ Misses      15058    13503    -1555     
+ Partials      181      110      -71     
Flag Coverage Δ
#cypress 55.82% <16.66%> (?)
#javascript 62.67% <16.66%> (-0.01%) ⬇️
#python 60.90% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/dashboard/actions/sliceEntities.js 78.78% <16.66%> (+69.11%) ⬆️
...et-frontend/src/SqlLab/components/LimitControl.tsx 84.78% <0.00%> (-1.89%) ⬇️
...-frontend/src/datasource/ChangeDatasourceModal.tsx 73.21% <0.00%> (-1.34%) ⬇️
superset/db_engine_specs/presto.py 81.42% <0.00%> (-0.65%) ⬇️
.../src/components/dataViewCommon/TableCollection.tsx 100.00% <0.00%> (ø)
...rontend/src/SqlLab/components/AceEditorWrapper.tsx 60.75% <0.00%> (+1.26%) ⬆️
...ashboard/components/gridComponents/ChartHolder.jsx 79.16% <0.00%> (+1.38%) ⬆️
...perset-frontend/src/components/CopyToClipboard.jsx 36.36% <0.00%> (+1.51%) ⬆️
...rset-frontend/src/explore/components/SaveModal.jsx 92.30% <0.00%> (+1.53%) ⬆️
...hboard/components/resizable/ResizableContainer.jsx 71.87% <0.00%> (+1.56%) ⬆️
... and 168 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e97c4f...0a755d1. Read the comment docs.

@nytai nytai marked this pull request as ready for review October 23, 2020 23:12
@nytai nytai linked an issue Oct 23, 2020 that may be closed by this pull request
3 tasks
@nytai nytai merged commit d02a61f into apache:master Oct 24, 2020
@nytai nytai deleted the tai/fetch-charts-by-owners branch October 24, 2020 21:45
graceguo-supercat pushed a commit to airbnb/superset-fork that referenced this pull request Nov 10, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 First shipped in 1.0.0 labels Mar 12, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.0.0 First shipped in 1.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dashboards: Can't use charts that you own but didn't create

4 participants