feat(dashboard): fetch charts by owners instead of created_by#11336
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11336 +/- ##
==========================================
+ Coverage 61.56% 65.67% +4.10%
==========================================
Files 835 835
Lines 39653 39658 +5
Branches 3604 3606 +2
==========================================
+ Hits 24414 26045 +1631
+ Misses 15058 13503 -1555
+ Partials 181 110 -71
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
3 tasks
bkyryliuk
approved these changes
Oct 23, 2020
mistercrunch
approved these changes
Oct 24, 2020
3 tasks
graceguo-supercat
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Nov 10, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
9 tasks
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
The charts tab in the dashboard edit pane fetches from
/sliceasync/api/read?_flt_0_created_by=2which are charts the user created. This updates switches over to using the new api endpoint for charts and fetches charts the user owns.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION