fix(examples): specify 'time_range_endpoints' to prevent toast warning#11417
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11417 +/- ##
=======================================
Coverage 66.55% 66.55%
=======================================
Files 860 860
Lines 40871 40871
Branches 3688 3688
=======================================
+ Hits 27201 27203 +2
+ Misses 13571 13570 -1
+ Partials 99 98 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
approved these changes
Oct 26, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
6 tasks
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Prevent this error message/toast on examples charts:
SIP-15 #6360 introduced new internal chart params that never got fixed in our examples, and the error message above have been showing up ever since. This PR addresses the error message by adding the required chart parameters to the examples as they get loaded.