fix: prevent race condition when canceling query

[betodealmeida]

SUMMARY

With the right timing, it's possible to cancel a query, see the message and toast saying "Query was stopped", but still have results being loaded in SQL Lab shortly after. I added a check to prevent this from happening.

Note that actions.QUERY_FAILED has a similar check.

I also noticed that this has been fixed in the past (#2164), but removed later (#4833). @graceguo-supercat and @john-bodley do you have context why it was removed? It doesn't seem obvious to me from the PR.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

The problem is hard to repro because of the sensitive timing, but I was able to make it happen twice by changing the examples database to async and canceling running queries at the right time.

After the fix was applied I wasn't able to repro the problem.

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[codecov-io]

Codecov Report

Merging #11449 into master will decrease coverage by 0.69%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11449      +/-   ##
==========================================
- Coverage   62.26%   61.57%   -0.70%     
==========================================
  Files         863      417     -446     
  Lines       40978    25960   -15018     
  Branches     3693        0    -3693     
==========================================
- Hits        25516    15984    -9532     
+ Misses      15283     9976    -5307     
+ Partials      179        0     -179     

Flag	Coverage Δ
#javascript	?
#python	61.57% <ø> (-0.35%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/db_engine_specs/mysql.py	79.59% <0.00%> (-12.25%)	⬇️
superset/db_engine_specs/sqlite.py	65.62% <0.00%> (-9.38%)	⬇️
superset/databases/commands/create.py	82.97% <0.00%> (-8.52%)	⬇️
superset/databases/commands/update.py	85.71% <0.00%> (-8.17%)	⬇️
superset/utils/celery.py	82.14% <0.00%> (-3.58%)	⬇️
superset/datasets/api.py	89.38% <0.00%> (-3.36%)	⬇️
superset/models/core.py	86.07% <0.00%> (-3.07%)	⬇️
superset/databases/api.py	87.73% <0.00%> (-2.84%)	⬇️
superset/views/core.py	71.76% <0.00%> (-2.59%)	⬇️
superset/db_engine_specs/postgres.py	97.56% <0.00%> (-2.44%)	⬇️
... and 451 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2636f0...2087bbc. Read the comment docs.

[rusackas]

another rebase should fix the broken E2E test.

[betodealmeida]

Thanks, @rusackas!

[john-bodley]

@betodealmeida sorry I don't recall anything beyond the comments in the original PR. Given that there is a similar check elsewhere and this seems to mitigate the problem the change LGTM.

[betodealmeida]

Thanks, @john-bodley!