refactor: Replace react-bootstrap MenuItems with Antd Menu#11554
Merged
Conversation
Member
Author
rusackas
reviewed
Nov 4, 2020
rusackas
reviewed
Nov 4, 2020
Member
There was a problem hiding this comment.
Any idea what this f16 class does (or the div, for that matter)?
Member
Author
There was a problem hiding this comment.
.f16 .flag-code and .f16 .flag provide styles for the flag icons
rusackas
reviewed
Nov 4, 2020
rusackas
reviewed
Nov 4, 2020
kgabryje
force-pushed
the
antd/menuitem-3
branch
from
473a79e to
2217af1
Compare
Member
Author
|
@rusackas This PR was bigger than it was supposed to be because I forgot to do the rebase and there were some changes that were already merged - I apologise for that. On the bright side, you caught some css in |
Codecov Report
@@ Coverage Diff @@
## master #11554 +/- ##
==========================================
+ Coverage 59.59% 62.27% +2.67%
==========================================
Files 832 876 +44
Lines 40482 42172 +1690
Branches 3666 3954 +288
==========================================
+ Hits 24126 26262 +2136
+ Misses 16187 15728 -459
- Partials 169 182 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Member
9 tasks
mistercrunch
added
🏷️ bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Replaces MenuItems in SliceHeaderControls, DisplayQueryButton and SliceAdder components.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
ADDITIONAL INFORMATION