fix(saved query): handle null sql field#11679
Merged
Merged
Conversation
5 tasks
villebro
approved these changes
Nov 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #11679 +/- ##
==========================================
- Coverage 62.86% 60.25% -2.61%
==========================================
Files 889 843 -46
Lines 43054 41339 -1715
Branches 4016 3729 -287
==========================================
- Hits 27064 24909 -2155
- Misses 15811 16265 +454
+ Partials 179 165 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
willbarrett
approved these changes
Nov 12, 2020
f6d366c to
c14d6c6
Compare
Member
Author
|
retriggering CI |
c14d6c6 to
c8c3616
Compare
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
There's an error in the typing of SavedQueryObject,
sqlfield can be null which causes the preview modal to error out.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
ADDITIONAL INFORMATION