refactor: Simplifying tabOverride logic in control sections

[rusackas]

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

Various control sections have been showing up under unexpected tabs. This PR makes it simpler/easier to shove control sections under the correct tab, by allowing "tabOverride" to be either "data" or "customize" and simplifying (essentially inverting) the logic that takes place when neither is specified. This also removes support for putting the "tabOverride" in a singular control, and just keeps it to the control section, for simplicity.

I have half a mind to just make it "tab" instead of "tabOverride" and bake it into every control section, as a standard practice... but I'll pocket that one, as a control layout refactor will likely be coming soon (reconsidering the current rows/columns approach). But that's another story, and probably another PR...

Also, there will be a PR over on superset-ui that utilizes this new "customize" value in numerous places. We can merge that one before this one, I think, and I'll bump all the chart versions as part of this PR when it exits draft mode.

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[codecov-io]

Codecov Report

Merging #11708 (dd67d59) into master (44e80e0) will decrease coverage by 3.08%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master   #11708      +/-   ##
==========================================
- Coverage   66.79%   63.71%   -3.09%     
==========================================
  Files         924      924              
  Lines       44837    44828       -9     
  Branches     4253     4247       -6     
==========================================
- Hits        29951    28562    -1389     
- Misses      14777    16089    +1312     
- Partials      109      177      +68     

Flag	Coverage Δ
cypress	?
javascript	63.03% <75.00%> (+<0.01%)	⬆️
python	64.11% <ø> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...et-frontend/src/explore/controlPanels/sections.jsx	100.00% <ø> (ø)
superset-frontend/src/explore/controls.jsx	26.82% <ø> (ø)
.../src/explore/components/ControlPanelsContainer.jsx	75.36% <75.00%> (-17.50%)	⬇️
superset-frontend/src/explore/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/dashboard/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/explore/index.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/dashboard/index.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/setup/setupColors.js	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/chart/ChartContainer.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/explore/reducers/index.js	0.00% <0.00%> (-100.00%)	⬇️
... and 160 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44e80e0...dd67d59. Read the comment docs.

[ktmud]

Related: #9495

[rusackas]

@ktmud / @kristw I opened this for review, as I think it's safe enough to merge on its own regardless of what I muddle around with over on the superset-ui side, but please check my sanity on this :D

[ktmud]

Instead of adding a customize option, I'd be more enthusiastic on getting rid of the "renderTrigger implies data tab" logic. To really keep things simple, we should just always default things to be on the customize tab and require explicit override if people want to display things in the Data tab (or other way around if it makes more sense).

But this change is probably safe since I didn't see any use of tabOverride at the control item level anymore.

[rusackas]

Instead of adding a customize option, I'd be more enthusiastic on getting rid of the "renderTrigger implies data tab" logic. To really keep things simple, we should just always default things to be on the customize tab and require explicit override if people want to display things in the Data tab (or other way around if it makes more sense).

But this change is probably safe since I didn't see any use of tabOverride at the control item level anymore.

Yep... I had an itchy trigger finger to remove that behavior entirely, but didn't want to cause any weird regressions. I'll do that in another PR once we've made some more updates on the superset-ui side and merged them in.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[amitmiran137]

closing this due to inactivity