feat: Native filters fast-follow by rusackas · Pull Request #12138 · apache/superset

rusackas · 2020-12-19T01:10:32Z

SUMMARY

Adds onto #11814

This branch isn't my own work so much as a party! This is a feature branch containing the excellent work of:
@suddjian
@villebro
@pkdotson
@agatapst
@simchanielsen
@ amitmiran137

NEW STUFF! 🎉
• adjust styling to match design spec
• better filter delete UX
• cascading filters
• error boundaries
• non-instant filtering
• default values

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

…ator-superset into dashboard-native-filters

…into scopes

…ator-superset into scopes

codecov-io · 2020-12-19T05:34:55Z

Codecov Report

Merging #12138 (e450af0) into master (865beae) will decrease coverage by 2.55%.
The diff coverage is 46.72%.

@@            Coverage Diff             @@
##           master   #12138      +/-   ##
==========================================
- Coverage   65.82%   63.26%   -2.56%     
==========================================
  Files         988      990       +2     
  Lines       48702    48902     +200     
  Branches     4907     4963      +56     
==========================================
- Hits        32056    30937    -1119     
- Misses      16501    17768    +1267     
- Partials      145      197      +52

Flag	Coverage Δ
cypress	`?`
javascript	`61.80% <46.72%> (-0.17%)`	⬇️
python	`64.20% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...nd/src/dashboard/components/nativeFilters/types.ts	`100.00% <ø> (ø)`
...hboard/components/nativeFilters/CascadePopover.tsx	`22.64% <22.64%> (ø)`
...c/dashboard/components/nativeFilters/FilterBar.tsx	`53.60% <43.75%> (-6.87%)`	⬇️
...ard/components/nativeFilters/FilterConfigModal.tsx	`60.24% <46.59%> (-9.76%)`	⬇️
...nd/src/dashboard/components/nativeFilters/utils.ts	`57.89% <47.05%> (-4.18%)`	⬇️
...ashboard/components/nativeFilters/ColumnSelect.tsx	`51.51% <60.00%> (+1.51%)`	⬆️
...oard/components/nativeFilters/FilterConfigForm.tsx	`80.35% <81.25%> (+3.08%)`	⬆️
...frontend/src/components/SupersetResourceSelect.tsx	`68.96% <83.33%> (+3.58%)`	⬆️
superset-frontend/src/utils/cacheWrapper.ts	`100.00% <100.00%> (ø)`
superset-frontend/src/explore/App.jsx	`0.00% <0.00%> (-100.00%)`	⬇️
... and 145 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 865beae...e450af0. Read the comment docs.

suddjian · 2020-12-19T05:43:12Z

+ */
+import { cacheWrapper } from 'src/utils/cacheWrapper';
+
+describe('cacheWrapper', () => {


suddjian · 2020-12-19T05:46:41Z

+    const currentValue = filter.currentValue || [];
+
+    const activeChildren = children.flatMap(
+      childFilter => getActiveChildren(childFilter) || [],


cool use of flatMap

suddjian · 2020-12-19T05:50:26Z

+    </>
+  );
+
+  const activeFilters = getActiveChildren(filter) || [filter];


Why are we calling these "active" filters? What exactly does that mean here?

suddjian · 2020-12-19T06:10:29Z


+  function getParentFilters(id: string) {
+    return filterIds
+      .filter(filterId => filterId !== id && !removedFilters[filterId])


Good catch keeping removed filters out

suddjian

The parts I didn't write LGTM!

junlincc · 2020-12-19T06:21:53Z

if the code looks good, let's merge first? we should test it we all other recent merged PRs

rusackas · 2020-12-19T07:13:41Z

Reviewed the code and it LGTM!

…t-io/incubator-superset into native-filters-fast-follow

* wip: filter create modal * add a feature flag * automatic changes to package lock * wip * filter sidebar and basic state management * move create button to the sidebar * first step for edit filterconfig * partially fix tests... * edits to types and comments * respect feature flag on the filter sidebar * add filterconfig form * get input state working * feat: tree filter scopes UI * fix: turn on flag * sticky filter bar * stop preferring default export * feat: finish filter scoping * fix: under toggle * fix: title * fix: add licence * refactor: update TS * fix: fix on reopen modal + validation * new filter bar menu * adding, but commenting out, bulk scoping action * adding some placeholder buttons and styles therefor * feat: add filter chart * add relative path to package.json * update modal * a little input styling... just getting warmed up * Revert "feat: add filter chart" This reverts commit b1302d3. * Revert "add relative path to package.json" This reverts commit 26a7b40. * https package lock idk * feat: add filter chart * add relative path to package.json * flexboxes all the way down * dynamically generate groupby and datasource in select control * big wip * fix target column name * no importing nonexistent things * styles and name editing * Add hook for retrieval of all filter states * start with a new filter when clicking add filter * handle removed filters gracefully * fix incorrect default filter configuration * add fields to useAllFilterState * add redux for filterconfigs * add support for native_filters * remove consoles * improve filter removal * unbreak infinite loop * basic sidebar toggling working! * collapsing and menu working more smoothly * linting * make dataset and column inputs work * save filter values properly * add dashboard event for filter updates * guarded * apply filters properly * fix schema * making New Filter button a link * gridunits ftw * centering modal * tis not a button anymore! nixing type. * plus and collapse buttons instead of "more" menu * updating full size filter icons * adding icons to filter collapsing/expanding * turning off animation, but leaving class-based animation css * fix linting error * fix native filters for legacy charts * updates test * no individual apply buttons * fix bugs with filter config modal * remove redundant code * switch to the filter with validation errors on submit * separate form validation * switch config button from add to edit * switch to the filter with validation errors on submit * separate form validation * switch config button from add to edit * update tests * oops forgot to add the fancy new useChangeEffect hook * comments and code reorganization * rename native_filters to extr_form_data and move hook * disable native filters in viz selector * add cascading * implement new extra form data api * cleanup * updates tests * bump npm packages * fix bad merge on package.json + lock * lint * replace in and not in with uppercase * lint * lint * lint * lint * bulk test fix * Sort select input alphabetically * Change type for sorting elements * sleeker filter removal UX * fix rest of unit tests * make filter operators all uppercase * Hide Filter bar when there are no filters * Show edit button for dashboard owners only * Add visible argument to filters toggle function to avoid future regression * Improve Toggle filters bar function * lint * fix js lint + set createNewOnOpen * Handle setting extra form data in Filter Bar instead of Filter Control * Add Handle apply filter function to Apply button * Allow applying changes instantly * Fix types * remove console logs * fix package * Add Error Boundary component to Filter bar and Filter Config Modal * fix jest tests * update native filters tests to pass * reset cypress baseUrl * remove unnecessary field * Add Parent Filter input field to Config Modal * Create Cascade Filter & display children filters * Add Cascade Popover * Display Filter value both in Filter Bar and in Cascade Popover * Display the youngest filter value label in the Filter bar * Add styles to Cascade Popover and filters * Force to apply changes instantly for parent filters and refactor styles * Show error for no cyclical hierarchy and refactor * Add validation for parent filter to be applied instantly * Add Error Boundary to Filter Config Modal * cleanup: remove unused state fields * move unrelated types to an appropriate location * remove misplaced resource fetch error logic * fix cascadeParentIds error * fix cypress password * initial attempt at fixing scope issue * fix bad merge * fix lint * trying out makeApi for saving filters * remove unused import * fix test * silence bad test * Improve styling of Filter Config Modal * Improve styles for whole native filters feature * Add styles for active filter tab * Fix text for scoping * Clean up Filter Bar and Config Modal styles * Remove fractional gridUnits. Change name for CheckboxFormItem. Add placeholder to Parent Filter select. * Remove unnecessary button size for Config Modal * add native-filter feat flag config * oops fix here * remove space * Update superset-frontend/src/common/components/index.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts Co-authored-by: Evan Rusackas <evan@preset.io> * Add Cache Wrapper helper to avoid datasets requests deduplication * Add license to new Cache Wrapper helper * Add Cache Wrapper tests * Fix expanding Filter Bar * use styledMount in tests * comment Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/nativeFilters/FilterConfigForm.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/nativeFilters/FilterConfigModal.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/nativeFilters/FilterConfigurationLink.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * address PR feedback * fix package lock * null guards * Fix charts resizing * removing emotion/react and going old school on css animation * fxing css glitch on scoping disclaimer * src paths. * using gridUnits * nixing unnecessary diamonds * linting * fix type errors * Inverting collapsed icons... closer to data src selector design * restoring feature flag to proper default setting * missing condition * fix tests * patching test * just a button * flaky tests Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com> Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com> Co-authored-by: Simcha Shats <simcha.shats@nielsen.com> Co-authored-by: amitNielsen <amit.miran@nielsen.com> Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com> Co-authored-by: Agata Stawarz-Pastewska <agata.stawarz-pastewska@polidea.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

suddjian and others added 30 commits November 3, 2020 11:46

wip: filter create modal

aa427c0

add a feature flag

12d2d4e

automatic changes to package lock

a5e33ae

wip

82b83d8

filter sidebar and basic state management

78bf0e9

move create button to the sidebar

7624042

Merge branch 'master' into dashboard-native-filters

8026e42

first step for edit filterconfig

c1afcb6

partially fix tests...

056d4d3

edits to types and comments

b1b40ea

respect feature flag on the filter sidebar

7388ced

add filterconfig form

eddd87e

Merge branch 'dashboard-native-filters' of github.com:preset-io/incub…

869f36e

…ator-superset into dashboard-native-filters

get input state working

40801fc

feat: tree filter scopes UI

3a2da31

fix: turn on flag

44c3e0c

sticky filter bar

a06b3cb

stop preferring default export

a4117f3

feat: finish filter scoping

d602700

Merge branch 'scopes' of github.com:simchaNielsen/incubator-superset …

cac8416

…into scopes

Merge branch 'dashboard-native-filters' of github.com:preset-io/incub…

dce5f46

…ator-superset into scopes

fix: under toggle

21d2b28

Merge branch 'master' into dashboard-native-filters

8422d54

fix: title

0949085

fix: add licence

344cd94

refactor: update TS

ae33570

fix: fix on reopen modal + validation

3f5ea72

new filter bar menu

d5d75f6

adding, but commenting out, bulk scoping action

cbb2c65

adding some placeholder buttons and styles therefor

b62e06d

suddjian reviewed Dec 19, 2020

View reviewed changes

suddjian approved these changes Dec 19, 2020

View reviewed changes

rusackas commented Dec 19, 2020

View reviewed changes

Comment thread superset-frontend/src/dashboard/components/nativeFilters/CascadePopover.tsx Outdated

rusackas added 3 commits December 18, 2020 22:46

src paths.

89f4511

using gridUnits

9257b69

nixing unnecessary diamonds

7f7ca50

rusackas commented Dec 19, 2020

View reviewed changes

Comment thread superset-frontend/src/utils/cacheWrapper.ts

rusackas and others added 10 commits December 18, 2020 23:24

linting

e2e6fcd

fix type errors

46f0330

Inverting collapsed icons... closer to data src selector design

8ffdcc7

Merge branch 'native-filters-fast-follow' of https://github.com/prese…

d22c8f8

…t-io/incubator-superset into native-filters-fast-follow

restoring feature flag to proper default setting

1da41ee

missing condition

e94f663

fix tests

3ded369

patching test

0ac9284

just a button

3250536

flaky tests

e450af0

suddjian merged commit 4a471b8 into apache:master Dec 19, 2020

junlincc mentioned this pull request Dec 19, 2020

[🎉New Feature for Testing]Dashboard native filter and cascading filter are HERE! #12148

Closed

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 First shipped in 1.0.0 labels Mar 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Native filters fast-follow#12138

feat: Native filters fast-follow#12138
suddjian merged 243 commits into
apache:masterfrom
preset-io:native-filters-fast-follow

rusackas commented Dec 19, 2020 •

edited

Loading

Uh oh!

codecov-io commented Dec 19, 2020 •

edited

Loading

Uh oh!

suddjian Dec 19, 2020

Uh oh!

suddjian Dec 19, 2020

Uh oh!

suddjian Dec 19, 2020

Uh oh!

suddjian Dec 19, 2020

Uh oh!

suddjian left a comment •

edited

Loading

Uh oh!

junlincc commented Dec 19, 2020 •

edited

Loading

Uh oh!

Uh oh!

rusackas commented Dec 19, 2020

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

rusackas commented Dec 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

Uh oh!

codecov-io commented Dec 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

suddjian Dec 19, 2020

Choose a reason for hiding this comment

Uh oh!

suddjian Dec 19, 2020

Choose a reason for hiding this comment

Uh oh!

suddjian Dec 19, 2020

Choose a reason for hiding this comment

Uh oh!

suddjian Dec 19, 2020

Choose a reason for hiding this comment

Uh oh!

suddjian left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

junlincc commented Dec 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

rusackas commented Dec 19, 2020

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

rusackas commented Dec 19, 2020 •

edited

Loading

codecov-io commented Dec 19, 2020 •

edited

Loading

suddjian left a comment •

edited

Loading

junlincc commented Dec 19, 2020 •

edited

Loading