[WIP] refactor: Converting TableElement.jsx to functional component#12949
Closed
lyndsiWilliams wants to merge 4 commits into
Closed
[WIP] refactor: Converting TableElement.jsx to functional component#12949lyndsiWilliams wants to merge 4 commits into
lyndsiWilliams wants to merge 4 commits into
Conversation
lyndsiWilliams
commented
Feb 4, 2021
Member
Author
|
Working on PR summary and testing. |
Codecov Report
@@ Coverage Diff @@
## master #12949 +/- ##
==========================================
- Coverage 66.92% 66.87% -0.06%
==========================================
Files 1024 489 -535
Lines 50185 28661 -21524
Branches 5213 0 -5213
==========================================
- Hits 33588 19166 -14422
+ Misses 16457 9495 -6962
+ Partials 140 0 -140
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Member
|
Do you want to set this as a "draft", too? |
Member
Author
|
Corbin has taken this over at this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
TableElement.jsx at src/SqlLab/components/TableElement.jsx converted from class to functional component.
TEST PLAN
Current tests are not passing, they make checks through component state which exists in class components but not in functional components. Below is a screenshot of the TableElement rendering correctly after converting from class to functional component.

ADDITIONAL INFORMATION