Skip to content

[WIP] refactor: Converting TableElement.jsx to functional component#12949

Closed
lyndsiWilliams wants to merge 4 commits into
apache:masterfrom
lyndsiWilliams:lyndsi/tableelement-to-functional
Closed

[WIP] refactor: Converting TableElement.jsx to functional component#12949
lyndsiWilliams wants to merge 4 commits into
apache:masterfrom
lyndsiWilliams:lyndsi/tableelement-to-functional

Conversation

@lyndsiWilliams
Copy link
Copy Markdown
Member

@lyndsiWilliams lyndsiWilliams commented Feb 4, 2021

SUMMARY

TableElement.jsx at src/SqlLab/components/TableElement.jsx converted from class to functional component.

TEST PLAN

Current tests are not passing, they make checks through component state which exists in class components but not in functional components. Below is a screenshot of the TableElement rendering correctly after converting from class to functional component.
Screen Shot 2021-02-05 at 10 46 38 AM

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@lyndsiWilliams lyndsiWilliams changed the title refactor: Converting TableElement.jsx to functional component [WIP] refactor: Converting TableElement.jsx to functional component Feb 4, 2021
Comment thread superset-frontend/src/SqlLab/components/TableElement.jsx Outdated
@lyndsiWilliams
Copy link
Copy Markdown
Member Author

lyndsiWilliams commented Feb 4, 2021

Working on PR summary and testing.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #12949 (4067237) into master (c781ab8) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12949      +/-   ##
==========================================
- Coverage   66.92%   66.87%   -0.06%     
==========================================
  Files        1024      489     -535     
  Lines       50185    28661   -21524     
  Branches     5213        0    -5213     
==========================================
- Hits        33588    19166   -14422     
+ Misses      16457     9495    -6962     
+ Partials      140        0     -140     
Flag Coverage Δ
cypress ?
javascript ?
python 66.87% <ø> (+2.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/views/database/views.py 62.69% <0.00%> (-24.88%) ⬇️
superset/databases/commands/create.py 83.67% <0.00%> (-8.17%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/db_engine_specs/elasticsearch.py 86.95% <0.00%> (-7.49%) ⬇️
superset/db_engine_specs/clickhouse.py 87.09% <0.00%> (-7.35%) ⬇️
superset/sql_validators/base.py 93.33% <0.00%> (-6.67%) ⬇️
superset/db_engine_specs/presto.py 82.25% <0.00%> (-6.28%) ⬇️
superset/db_engine_specs/sqlite.py 90.62% <0.00%> (-6.25%) ⬇️
superset/db_engine_specs/base.py 79.85% <0.00%> (-6.12%) ⬇️
... and 566 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c781ab8...4067237. Read the comment docs.

@eschutho
Copy link
Copy Markdown
Member

eschutho commented Feb 5, 2021

Do you want to set this as a "draft", too?

@lyndsiWilliams lyndsiWilliams marked this pull request as draft February 5, 2021 17:30
@lyndsiWilliams
Copy link
Copy Markdown
Member Author

Corbin has taken this over at this PR.

@lyndsiWilliams lyndsiWilliams deleted the lyndsi/tableelement-to-functional branch June 1, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants