Skip to content

fix: Revert "refactor: split db modal file (#14436)"#14466

Merged
hughhhh merged 1 commit into
apache:masterfrom
preset-io:elizabeth/revert-db-modal-changes
May 4, 2021
Merged

fix: Revert "refactor: split db modal file (#14436)"#14466
hughhhh merged 1 commit into
apache:masterfrom
preset-io:elizabeth/revert-db-modal-changes

Conversation

@eschutho
Copy link
Copy Markdown
Member

@eschutho eschutho commented May 4, 2021

This reverts commit 2d991ec.

SUMMARY

Some form fields aren't being passed into state correctly. This reverts that commit.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2021

Codecov Report

Merging #14466 (50f1ec4) into master (21cf12a) will decrease coverage by 0.01%.
The diff coverage is 63.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14466      +/-   ##
==========================================
- Coverage   77.12%   77.11%   -0.02%     
==========================================
  Files         954      952       -2     
  Lines       48175    48152      -23     
  Branches     6063     6054       -9     
==========================================
- Hits        37155    37131      -24     
- Misses      10819    10820       +1     
  Partials      201      201              
Flag Coverage Δ
javascript 71.91% <63.15%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/views/CRUD/data/database/DatabaseModal.tsx 62.87% <62.87%> (ø)
...et-frontend/src/views/CRUD/data/database/styles.ts 96.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21cf12a...50f1ec4. Read the comment docs.

@hughhhh hughhhh changed the title Revert "refactor: split db modal file (#14436)" fix: Revert "refactor: split db modal file (#14436)" May 4, 2021
@hughhhh hughhhh self-assigned this May 4, 2021
@hughhhh hughhhh self-requested a review May 4, 2021 18:40
@hughhhh hughhhh removed their assignment May 4, 2021
@hughhhh hughhhh merged commit 2242f74 into apache:master May 4, 2021
hughhhh pushed a commit that referenced this pull request May 4, 2021
@eschutho eschutho deleted the elizabeth/revert-db-modal-changes branch May 10, 2021 15:56
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants