Skip to content

feat: db modal split#14470

Merged
hughhhh merged 3 commits into
apache:masterfrom
preset-io:elizabeth/db_modal_refactor
May 5, 2021
Merged

feat: db modal split#14470
hughhhh merged 3 commits into
apache:masterfrom
preset-io:elizabeth/db_modal_refactor

Conversation

@eschutho
Copy link
Copy Markdown
Member

@eschutho eschutho commented May 4, 2021

SUMMARY

This change sets us up to switch between tabs and screens in the next iteration of the new db connection ui flow.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

The only change visually is the title and button on Create/Connect a database
_DEV__Superset

TEST PLAN

Tests should all pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh
Copy link
Copy Markdown
Member

hughhhh commented May 4, 2021

/testenv up

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2021

@hughhhh Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2021

@hughhhh Ephemeral environment creation failed. Please check the Actions logs for details.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2021

Codecov Report

Merging #14470 (f97f133) into master (d138b44) will increase coverage by 0.00%.
The diff coverage is 70.71%.

❗ Current head f97f133 differs from pull request most recent head 5cc4025. Consider uploading reports for the commit 5cc4025 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14470   +/-   ##
=======================================
  Coverage   77.11%   77.12%           
=======================================
  Files         952      954    +2     
  Lines       48156    48175   +19     
  Branches     6054     6055    +1     
=======================================
+ Hits        37137    37154   +17     
- Misses      10818    10820    +2     
  Partials      201      201           
Flag Coverage Δ
javascript 71.94% <71.17%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Label/index.tsx 100.00% <ø> (ø)
...nd/src/explore/components/ExploreViewContainer.jsx 2.33% <ø> (ø)
...ontrols/FilterControl/AdhocFilterControl/index.jsx 57.69% <ø> (ø)
...components/controls/FixedOrMetricControl/index.jsx 83.92% <ø> (ø)
superset-frontend/src/views/menu.tsx 0.00% <0.00%> (ø)
superset/views/core.py 75.49% <25.00%> (-0.15%) ⬇️
superset/views/utils.py 84.06% <50.00%> (ø)
...c/views/CRUD/data/database/DatabaseModal/index.tsx 56.60% <56.60%> (ø)
.../CRUD/data/database/DatabaseModal/ExtraOptions.tsx 93.33% <93.33%> (ø)
...t-frontend/src/SqlLab/components/ColumnElement.tsx 95.45% <100.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d138b44...5cc4025. Read the comment docs.

@hughhhh
Copy link
Copy Markdown
Member

hughhhh commented May 4, 2021

/testenv up

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2021

@hughhhh Ephemeral environment spinning up at http://54.185.177.209:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@eschutho
Copy link
Copy Markdown
Member Author

eschutho commented May 4, 2021

I tested and found that an id is being passed on creation. I'll put up a fix.

@junlincc
Copy link
Copy Markdown
Member

junlincc commented May 4, 2021

thanks for the PR! @eschutho
For QA:
Tab in this modal shares the same AntD component used in Global nav bar, Metric popover, Filter popover in Explore, and a few others. When there are changes made in any of those areas, please make sure we spot test the others.
@rosemarie-chiu @jinghua-qa

@eschutho
Copy link
Copy Markdown
Member Author

eschutho commented May 5, 2021

Thanks @junlincc. @hughhhh can you create another ephemeral env? I've updated the PR.

@eschutho eschutho force-pushed the elizabeth/db_modal_refactor branch from 5302f36 to 5cc4025 Compare May 5, 2021 00:23
@eschutho
Copy link
Copy Markdown
Member Author

eschutho commented May 5, 2021

The failing test is passing for me locally, and doesn't look related to this code. @hughhhh can you try restarting it? thank you!

@eschutho eschutho mentioned this pull request May 5, 2021
8 tasks
@hughhhh hughhhh self-requested a review May 5, 2021 17:46
@hughhhh
Copy link
Copy Markdown
Member

hughhhh commented May 5, 2021

/testenv up

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2021

@hughhhh Ephemeral environment spinning up at http://34.211.107.19:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@hughhhh hughhhh merged commit 9b42eec into apache:master May 5, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2021

Ephemeral environment shutdown and build artifacts deleted.

@eschutho eschutho deleted the elizabeth/db_modal_refactor branch May 10, 2021 15:56
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* refactor: split db modal file (apache#14436)

* split db modal file

* fix tests

* fix extra options

* update database id methodology
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* refactor: split db modal file (apache#14436)

* split db modal file

* fix tests

* fix extra options

* update database id methodology
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* refactor: split db modal file (apache#14436)

* split db modal file

* fix tests

* fix extra options

* update database id methodology
@mistercrunch mistercrunch added the 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels label Mar 12, 2024
@mistercrunch mistercrunch added the 🚢 1.3.0 First shipped in 1.3.0 label Mar 12, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
* refactor: split db modal file (apache#14436)

* split db modal file

* fix tests

* fix extra options

* update database id methodology
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XXL 🚢 1.3.0 First shipped in 1.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants