feat: Add a remove_filter flag to the jinja filter_values function and add a new get_filters function (see issue 13943 for more details) by cccs-jc · Pull Request #14507 · apache/superset

cccs-jc · 2021-05-06T18:44:23Z

SUMMARY

Implementation of issue #13943.
Feature must be enabled with feature flag ENABLE_TEMPLATE_REMOVE_FILTERS.

SCREENSHOT

codecov · 2021-05-07T11:54:05Z

Codecov Report

Merging #14507 (7a63a3c) into master (96289e9) will increase coverage by 0.15%.
The diff coverage is 81.77%.

❗ Current head 7a63a3c differs from pull request most recent head b51aac5. Consider uploading reports for the commit b51aac5 to get more accurate results

@@            Coverage Diff             @@
##           master   #14507      +/-   ##
==========================================
+ Coverage   77.14%   77.30%   +0.15%     
==========================================
  Files         958      960       +2     
  Lines       48241    48775     +534     
  Branches     5636     6122     +486     
==========================================
+ Hits        37217    37707     +490     
- Misses      10823    10862      +39     
- Partials      201      206       +5

Flag	Coverage Δ
hive	`?`
mysql	`81.39% <87.76%> (+0.33%)`	⬆️
postgres	`81.41% <87.76%> (+0.32%)`	⬆️
presto	`?`
python	`81.49% <87.76%> (-0.13%)`	⬇️
sqlite	`81.03% <87.23%> (+0.32%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/CRUD/Fieldset.jsx	`85.71% <ø> (ø)`
superset-frontend/src/SqlLab/App.jsx	`0.00% <0.00%> (ø)`
superset-frontend/src/SqlLab/actions/sqlLab.js	`58.97% <ø> (ø)`
...-frontend/src/SqlLab/components/SouthPane/state.ts	`100.00% <ø> (ø)`
...erset-frontend/src/SqlLab/components/SqlEditor.jsx	`54.62% <ø> (ø)`
...et-frontend/src/SqlLab/components/TableElement.jsx	`89.02% <ø> (ø)`
...ontend/src/common/hooks/apiResources/dashboards.ts	`40.00% <0.00%> (-10.00%)`	⬇️
...et-frontend/src/components/EditableTitle/index.tsx	`83.95% <ø> (ø)`
...rset-frontend/src/components/ErrorMessage/types.ts	`100.00% <ø> (ø)`
...src/components/FilterableTable/FilterableTable.tsx	`82.26% <ø> (ø)`
... and 183 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96289e9...b51aac5. Read the comment docs.

mistercrunch · 2021-05-07T23:07:11Z

Nit: Let's give meaningful titles to PRs so that we can get a sense for the PR from the list of PRs without having to click through to the issue. The PR title also becomes the commit msg in master as we squash and merge.

junlincc · 2021-05-08T06:57:07Z

thank you jc for the contribution! really excited about this new feature. could you add screenshot of ui changes, as well as manual test plan? added hold tag

junlincc · 2021-05-10T19:52:47Z

thanks for adding video :) !

@villebro @zhaoyongjie is this gonna partially solve the "jinja filter status not applied on dashboard" problem?

junlincc · 2021-05-10T19:53:32Z

/testenv up

github-actions · 2021-05-10T19:55:38Z

@junlincc Ephemeral environment spinning up at http://34.211.207.26:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

cccs-jc · 2021-05-11T20:35:35Z

is this gonna partially solve the "jinja filter status not applied on dashboard" problem?

@junlincc it does in the sense that you can declare a column which you intend to only use as a filter. You can then handle that filter in your jinja template and mark it as remote_filter=True.

To prevent users from picking the column as a select column. We uncheck the Is Dimension flag in the dataset UI.

cccs-jc · 2021-05-19T10:27:25Z

@villebro all tests pass. I think it's ready to be merged.

junlincc · 2021-05-20T05:22:49Z

thank you so much for addressing the comments! @villebro please do help unblock jc 🙏

villebro

Code LGTM - Let me give this a test run and approve if all is ok! 👍

villebro

Awesome work JC, really great feature and works really well! Left a few additional comments, with one functional question relating to casting val to str. Let me know what you think.

villebro

Some last minute type nits

villebro · 2021-05-21T11:45:15Z

I think here we need to assume val can be Optional[Union[Any, List[Any]]]

are you okay with Union[None, Any, List[Any]]

villebro · 2021-05-21T11:46:14Z

I think the return value is List[Any]

villebro · 2021-05-21T11:46:35Z

Same here: List[Any]

Implementation issue 13943

villebro

LGTM, thanks for the hard work on this awesome feature JC!

github-actions · 2021-05-21T16:53:16Z

Ephemeral environment shutdown and build artifacts deleted.

…e#14507) Implementation issue 13943 Co-authored-by: cccs-jc <cccs-jc@cyber.gc.ca>

pull-request-size Bot added the size/L label May 6, 2021

cccs-jc force-pushed the issue_13943 branch from 091477f to e864a95 Compare May 7, 2021 11:39

cccs-jc changed the title ~~Implementation issue 13943~~ feat: Implementation issue 13943 May 7, 2021

cccs-jc force-pushed the issue_13943 branch 5 times, most recently from 9c4990d to a3c7eb2 Compare May 7, 2021 15:21

villebro reviewed May 7, 2021

View reviewed changes

Comment thread superset/jinja_context.py Outdated

Comment thread superset/jinja_context.py Outdated

Comment thread superset/jinja_context.py Outdated

Comment thread superset/connectors/sqla/models.py Outdated

Comment thread superset/jinja_context.py Outdated

junlincc added the hold:testing! On hold for testing label May 8, 2021

cccs-jc force-pushed the issue_13943 branch 4 times, most recently from fc116f4 to 8eaecac Compare May 8, 2021 16:51

cccs-jc changed the title ~~feat: Implementation issue 13943~~ feat: Add a remove_filter flag to the jinja filter_values function and add a new get_filters function (see issue 13943 for more details) May 8, 2021

cccs-jc force-pushed the issue_13943 branch from 8eaecac to 8057e08 Compare May 9, 2021 13:07

junlincc removed the hold:testing! On hold for testing label May 10, 2021

junlincc added the hold:testing! On hold for testing label May 10, 2021

cccs-jc force-pushed the issue_13943 branch 4 times, most recently from 6c5d4a2 to fe9df0c Compare May 12, 2021 20:57

junlincc removed the hold:testing! On hold for testing label May 13, 2021

villebro reviewed May 20, 2021

View reviewed changes

Comment thread superset/jinja_context.py Outdated

Comment thread superset/jinja_context.py Outdated

Comment thread superset/jinja_context.py Outdated

villebro reviewed May 20, 2021

View reviewed changes

Comment thread superset/jinja_context.py Outdated

cccs-jc force-pushed the issue_13943 branch from 681f5d7 to 5b2f800 Compare May 21, 2021 11:12

villebro reviewed May 21, 2021

View reviewed changes

cccs-jc force-pushed the issue_13943 branch from 5b2f800 to 65ef009 Compare May 21, 2021 13:51

Implementation issue 13943

b51aac5

Implementation issue 13943

cccs-jc force-pushed the issue_13943 branch from 65ef009 to b51aac5 Compare May 21, 2021 14:08

villebro approved these changes May 21, 2021

View reviewed changes

villebro merged commit 590fe20 into apache:master May 21, 2021

cccs-jc added a commit to CybercentreCanada/superset that referenced this pull request May 27, 2021

feat: Add a remove filter_flag to jinja filter_values function (apach…

ff35320

…e#14507) Implementation issue 13943 Co-authored-by: cccs-jc <cccs-jc@cyber.gc.ca>

cccs-jc pushed a commit to CybercentreCanada/superset that referenced this pull request May 30, 2021

code review apache#14507 don't save filters attribute

a3f1f11

cccs-jc pushed a commit to CybercentreCanada/superset that referenced this pull request May 30, 2021

typing apache#14507

6dc1394

cccs-joel pushed a commit to CybercentreCanada/superset that referenced this pull request May 31, 2021

feat: Add a remove filter_flag to jinja filter_values function (apach…

6f60476

…e#14507) Implementation issue 13943 Co-authored-by: cccs-jc <cccs-jc@cyber.gc.ca>

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Sep 2, 2021

feat: Add a remove filter_flag to jinja filter_values function (apach…

ead7402

…e#14507) Implementation issue 13943 Co-authored-by: cccs-jc <cccs-jc@cyber.gc.ca>

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Sep 8, 2021

feat: Add a remove filter_flag to jinja filter_values function (apach…

de5be67

…e#14507) Implementation issue 13943 Co-authored-by: cccs-jc <cccs-jc@cyber.gc.ca>

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021

feat: Add a remove filter_flag to jinja filter_values function (apach…

0ce5589

…e#14507) Implementation issue 13943 Co-authored-by: cccs-jc <cccs-jc@cyber.gc.ca>

QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021

feat: Add a remove filter_flag to jinja filter_values function (apach…

df9f8dc

…e#14507) Implementation issue 13943 Co-authored-by: cccs-jc <cccs-jc@cyber.gc.ca>

cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024

code review apache#14507 don't save filters attribute

847efd5

cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024

typing apache#14507

5125040

cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024

feat: Add a remove filter_flag to jinja filter_values function (apach…

e25ca18

…e#14507) Implementation issue 13943 Co-authored-by: cccs-jc <cccs-jc@cyber.gc.ca>

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 First shipped in 1.3.0 labels Mar 12, 2024

qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026

feat: Add a remove filter_flag to jinja filter_values function (apach…

8430ddb

…e#14507) Implementation issue 13943 Co-authored-by: cccs-jc <cccs-jc@cyber.gc.ca>

Conversation

cccs-jc commented May 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

SCREENSHOT

Uh oh!

codecov Bot commented May 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mistercrunch commented May 7, 2021

Uh oh!

junlincc commented May 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

junlincc commented May 10, 2021

Uh oh!

junlincc commented May 10, 2021

Uh oh!

github-actions Bot commented May 10, 2021

Uh oh!

cccs-jc commented May 11, 2021

Uh oh!

cccs-jc commented May 19, 2021

Uh oh!

junlincc commented May 20, 2021

Uh oh!

villebro left a comment

Choose a reason for hiding this comment

Uh oh!

villebro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

villebro left a comment

Choose a reason for hiding this comment

Uh oh!

villebro May 21, 2021

Choose a reason for hiding this comment

Uh oh!

cccs-jc May 21, 2021

Choose a reason for hiding this comment

Uh oh!

villebro May 21, 2021

Choose a reason for hiding this comment

Uh oh!

villebro May 21, 2021

Choose a reason for hiding this comment

Uh oh!

villebro May 21, 2021

Choose a reason for hiding this comment

Uh oh!

villebro left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cccs-jc commented May 6, 2021 •

edited

Loading

codecov Bot commented May 7, 2021 •

edited

Loading

junlincc commented May 8, 2021 •

edited

Loading