Skip to content

fix: Menu does not appear on scroll in Dashboard #14566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
suddjian merged 2 commits into from
May 11, 2021
Merged

fix: Menu does not appear on scroll in Dashboard #14566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92806f9
Fix menu
geido May 11, 2021
7073780
Fix test
geido May 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...tend/src/dashboard/components/Header/HeaderActionsDropdown/HeaderActionsDropdown.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ const editModeOnProps = {

function setup(props: HeaderDropdownProps) {
return (
<div className="dashboard">
<div className="dashboard-header">
<HeaderActionsDropdown {...props} />
</div>
);
Expand Down
2 changes: 1 addition & 1 deletion superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ class HeaderActionsDropdown extends React.PureComponent {
overlay={menu}
trigger={['click']}
getPopupContainer={triggerNode =>
triggerNode.closest(SCREENSHOT_NODE_SELECTOR)
triggerNode.closest('.dashboard-header')
}
>
<DropdownButton id="save-dash-split-button" role="button">
Expand Down
4 changes: 0 additions & 4 deletions superset-frontend/stylesheets/superset.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,7 +603,3 @@ hr {
top: 269px !important;
}
}

.ant-dropdown.ant-dropdown-placement-bottomRight {
top: 133px !important;
Copy link
Copy Markdown
Member Author

@geido geido May 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkdotson this was introduced by PR #14184. Not sure what side effects might have removing it, but in general it seems that the approach of forcing the positions might not be the right one in the first place.

The potential issues were also reported by @rusackas on this review comment https://github.com/apache/superset/pull/14184/files#r626190039 but were then overlooked. I would please ask you to have a look at that portion of the changes and find different solutions. I am pretty sure this is not the only issue that we might face.

Copy link
Copy Markdown
Member

@junlincc junlincc May 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the investigation!@geido @pkdotson how much refactoring left in this project?

@jinghua-qa

}