fix: Adds space under dataset change warning#14582
Merged
Merged
Conversation
rusackas
commented
May 12, 2021
Comment on lines
-63
to
+72
| padding: '6px 10px', | ||
| marginBottom: roomBelow ? gridUnit * 4 : 0, | ||
| padding: `${gridUnit * 2}px ${gridUnit * 3}px`, | ||
| alignItems: 'flex-start', | ||
| border: 0, | ||
| backgroundColor: baseColor.light2, | ||
| '& .ant-alert-icon': { | ||
| marginRight: 10, | ||
| marginRight: gridUnit * 2, |
Member
Author
There was a problem hiding this comment.
Happened to see some pixel measurements in here that I figured I might as well convert to gridUnits while we're in here. Trying to keep bycatch minimal these days, but... I couldn't help myself.
Member
Author
Codecov Report
@@ Coverage Diff @@
## master #14582 +/- ##
==========================================
- Coverage 77.40% 77.32% -0.08%
==========================================
Files 958 958
Lines 48327 48329 +2
Branches 5677 5679 +2
==========================================
- Hits 37406 37369 -37
- Misses 10721 10760 +39
Partials 200 200
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Member
|
/testenv up |
Contributor
|
@junlincc Ephemeral environment spinning up at http://52.88.27.249:8080. Credentials are |
Member
|
Lgtm thank you for the fix 😊 |
Contributor
|
Ephemeral environment shutdown and build artifacts deleted. |
henryyeh
pushed a commit
to preset-io/superset
that referenced
this pull request
May 18, 2021
* fix: Adding a little margin under the warning about changing datasets * feat: moves Alert spacing from a css override to an Alert prop * fix: prop needs to be optional... proptional * fix: moving the typing to a better spot, adding the new prop to storybook. * style: linting (cherry picked from commit 6d786d4)
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* fix: Adding a little margin under the warning about changing datasets * feat: moves Alert spacing from a css override to an Alert prop * fix: prop needs to be optional... proptional * fix: moving the typing to a better spot, adding the new prop to storybook. * style: linting
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* fix: Adding a little margin under the warning about changing datasets * feat: moves Alert spacing from a css override to an Alert prop * fix: prop needs to be optional... proptional * fix: moving the typing to a better spot, adding the new prop to storybook. * style: linting
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* fix: Adding a little margin under the warning about changing datasets * feat: moves Alert spacing from a css override to an Alert prop * fix: prop needs to be optional... proptional * fix: moving the typing to a better spot, adding the new prop to storybook. * style: linting
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
* fix: Adding a little margin under the warning about changing datasets * feat: moves Alert spacing from a css override to an Alert prop * fix: prop needs to be optional... proptional * fix: moving the typing to a better spot, adding the new prop to storybook. * style: linting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes a missing gutter under the warning you see when you change datasets in explore. Started doing this as a css override to fix the acute problem, but decided it'd be better to add it as a prop to the Alert itself in case we see this sort of thing again.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
Check it out in the Explore view by switching dataset. Or try the prop in the Interactive Alert entry of Storybook
ADDITIONAL INFORMATION