Skip to content

fix: bring back dashboard perf logger#14584

Merged
etr2460 merged 2 commits into
apache:masterfrom
graceguo-supercat:gg-FixDashboardPerfLogging
May 12, 2021
Merged

fix: bring back dashboard perf logger#14584
etr2460 merged 2 commits into
apache:masterfrom
graceguo-supercat:gg-FixDashboardPerfLogging

Conversation

@graceguo-supercat
Copy link
Copy Markdown

SUMMARY

The dashboard perf logging function was lost during #14356.

Expected behavior

Dashboard should send perf logging data:
Screen Shot 2021-05-11 at 7 05 41 PM

TEST PLAN

CI and manual test

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2021

Codecov Report

Merging #14584 (0e381d5) into master (7d28225) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14584   +/-   ##
=======================================
  Coverage   77.40%   77.40%           
=======================================
  Files         958      958           
  Lines       48327    48331    +4     
  Branches     5677     5679    +2     
=======================================
+ Hits        37406    37410    +4     
  Misses      10721    10721           
  Partials      200      200           
Flag Coverage Δ
javascript 72.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/dashboard/actions/hydrate.js 1.75% <ø> (ø)
superset-frontend/src/views/store.ts 100.00% <100.00%> (ø)
superset-frontend/src/components/Alert/index.tsx 100.00% <0.00%> (ø)
...-frontend/src/datasource/ChangeDatasourceModal.tsx 85.36% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d28225...0e381d5. Read the comment docs.

@graceguo-supercat graceguo-supercat force-pushed the gg-FixDashboardPerfLogging branch from 507765e to ac94bb5 Compare May 12, 2021 02:33
@graceguo-supercat graceguo-supercat force-pushed the gg-FixDashboardPerfLogging branch from ac94bb5 to ca7f1b0 Compare May 12, 2021 08:20
@graceguo-supercat graceguo-supercat force-pushed the gg-FixDashboardPerfLogging branch from ca7f1b0 to 0e381d5 Compare May 12, 2021 08:36
Copy link
Copy Markdown
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fix!

@etr2460 etr2460 merged commit ada3809 into apache:master May 12, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* fix: bring back dashboard perf logger

* add test
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* fix: bring back dashboard perf logger

* add test
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* fix: bring back dashboard perf logger

* add test
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 First shipped in 1.3.0 labels Mar 12, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
* fix: bring back dashboard perf logger

* add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.3.0 First shipped in 1.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants