Skip to content

fix: error icon spacing in explore#14597

Merged
rusackas merged 2 commits into
apache:masterfrom
preset-io:fix-thumbnail-padding
May 13, 2021
Merged

fix: error icon spacing in explore#14597
rusackas merged 2 commits into
apache:masterfrom
preset-io:fix-thumbnail-padding

Conversation

@pkdotson
Copy link
Copy Markdown
Member

SUMMARY

This pr fixes the padding issue for the error message in explore.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before:
Screen Shot 2021-05-12 at 5 45 50 PM

after:
Screen Shot 2021-05-12 at 5 46 36 PM

TEST PLAN

ADDITIONAL INFORMATION

  • [x ] Has associated issue: 14570
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2021

Codecov Report

Merging #14597 (5bb0f62) into master (0d240c3) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14597      +/-   ##
==========================================
+ Coverage   77.16%   77.18%   +0.01%     
==========================================
  Files         958      958              
  Lines       48331    48332       +1     
  Branches     5679     5680       +1     
==========================================
+ Hits        37295    37305      +10     
+ Misses      10836    10827       -9     
  Partials      200      200              
Flag Coverage Δ
javascript 72.51% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontend/src/explore/components/QueryAndSaveBtns.jsx 70.00% <0.00%> (ø)
...components/DashboardBuilder/DashboardContainer.tsx 100.00% <0.00%> (ø)
...ontend/src/filters/components/Select/buildQuery.ts 100.00% <0.00%> (+75.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76a06a7...5bb0f62. Read the comment docs.

@junlincc
Copy link
Copy Markdown
Member

/testenv up

@junlincc junlincc added the bash! label May 13, 2021
@junlincc junlincc changed the title fix: error message in explore fix: error icon spacing in explore May 13, 2021
@github-actions
Copy link
Copy Markdown
Contributor

@junlincc Ephemeral environment spinning up at http://54.245.41.232:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Copy Markdown

@junlin-qa junlin-qa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! product sign-off

@junlincc junlincc added the need:review Requires a code review label May 13, 2021
Copy link
Copy Markdown
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas rusackas merged commit 5f7722c into apache:master May 13, 2021
@rusackas rusackas deleted the fix-thumbnail-padding branch May 13, 2021 05:42
@github-actions
Copy link
Copy Markdown
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@junlincc junlincc added the rush! Requires immediate attention label May 18, 2021
henryyeh pushed a commit to preset-io/superset that referenced this pull request May 18, 2021
* fix error message icon

* lint

(cherry picked from commit 5f7722c)
@junlincc junlincc removed the rush! Requires immediate attention label May 27, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* fix error message icon

* lint
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* fix error message icon

* lint
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* fix error message icon

* lint
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 First shipped in 1.3.0 labels Mar 12, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
* fix error message icon

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:review Requires a code review preset-io size/XS 🚢 1.3.0 First shipped in 1.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants