Skip to content

fix(explore): Filters Tooltip is not showing the full content#14618

Merged
suddjian merged 2 commits into
apache:masterfrom
geido:fix/issue_14571
May 13, 2021
Merged

fix(explore): Filters Tooltip is not showing the full content#14618
suddjian merged 2 commits into
apache:masterfrom
geido:fix/issue_14571

Conversation

@geido
Copy link
Copy Markdown
Member

@geido geido commented May 13, 2021

SUMMARY

Fixes #14571

Introduces a function to get the tooltip title in order to show the full content in the tooltip.

BEFORE

117864886-27ccf680-b24a-11eb-910c-22cd6df3fae3

AFTER

Screen Shot 2021-05-13 at 12 57 36

TEST PLAN

  1. Open a chart in Explore
  2. Add a new Filter using the IN operator
  3. Select a multitude of options and save the filter
  4. Hover the newly created filter
  5. Make sure that the tooltip is showing all the options

ADDITIONAL INFORMATION

  • Has associated issue: [cosmetic] filter tooltip missing selected values #14571
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido
Copy link
Copy Markdown
Member Author

geido commented May 13, 2021

@junlincc @rusackas

@geido geido changed the title fix: Filters Tooltip is not showing the full content fix(explore): Filters Tooltip is not showing the full content May 13, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2021

Codecov Report

Merging #14618 (12973d4) into master (3f6bd1e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 12973d4 differs from pull request most recent head e68838f. Consider uploading reports for the commit e68838f to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14618   +/-   ##
=======================================
  Coverage   77.38%   77.38%           
=======================================
  Files         959      959           
  Lines       48465    48467    +2     
  Branches     5678     5678           
=======================================
+ Hits        37506    37508    +2     
  Misses      10759    10759           
  Partials      200      200           
Flag Coverage Δ
javascript 72.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...controls/FilterControl/AdhocFilterOption/index.jsx 100.00% <ø> (ø)
...onents/controls/FilterControl/AdhocFilter/index.js 97.01% <100.00%> (+0.09%) ⬆️
...plore/components/controls/OptionControls/index.tsx 90.52% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f6bd1e...e68838f. Read the comment docs.

Copy link
Copy Markdown
Member

@suddjian suddjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@suddjian suddjian merged commit 1e60148 into apache:master May 13, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 First shipped in 1.3.0 labels Mar 12, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.3.0 First shipped in 1.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cosmetic] filter tooltip missing selected values

3 participants