Skip to content

chore: Change name to BaseParameters to BasicParameters#14625

Merged
hughhhh merged 1 commit into
masterfrom
hugh/change-base-basic-mixin
May 13, 2021
Merged

chore: Change name to BaseParameters to BasicParameters#14625
hughhhh merged 1 commit into
masterfrom
hugh/change-base-basic-mixin

Conversation

@hughhhh
Copy link
Copy Markdown
Member

@hughhhh hughhhh commented May 13, 2021

SUMMARY

Renaming BaseParameters to BasicParameters

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Copy Markdown
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2021

Codecov Report

Merging #14625 (0299e20) into master (568061e) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 0299e20 differs from pull request most recent head 7d26f81. Consider uploading reports for the commit 7d26f81 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14625      +/-   ##
==========================================
- Coverage   77.46%   77.38%   -0.08%     
==========================================
  Files         959      959              
  Lines       48465    48467       +2     
  Branches     5678     5678              
==========================================
- Hits        37545    37508      -37     
- Misses      10720    10759      +39     
  Partials      200      200              
Flag Coverage Δ
hive 80.96% <100.00%> (-0.01%) ⬇️
mysql 81.24% <100.00%> (ø)
postgres 81.26% <100.00%> (ø)
presto ?
python 81.63% <100.00%> (-0.16%) ⬇️
sqlite 80.88% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...controls/FilterControl/AdhocFilterOption/index.jsx 100.00% <ø> (ø)
...onents/controls/FilterControl/AdhocFilter/index.js 97.01% <100.00%> (+0.09%) ⬆️
...plore/components/controls/OptionControls/index.tsx 90.52% <100.00%> (ø)
superset/databases/api.py 92.41% <100.00%> (ø)
superset/databases/commands/validate.py 76.00% <100.00%> (ø)
superset/databases/schemas.py 99.54% <100.00%> (ø)
superset/db_engine_specs/base.py 88.42% <100.00%> (ø)
superset/db_engine_specs/postgres.py 96.93% <100.00%> (ø)
superset/db_engine_specs/presto.py 84.42% <0.00%> (-5.48%) ⬇️
superset/connectors/sqla/models.py 88.82% <0.00%> (-1.45%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 568061e...7d26f81. Read the comment docs.

@hughhhh hughhhh merged commit 3a81e6a into master May 13, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@rusackas rusackas deleted the hugh/change-base-basic-mixin branch January 30, 2023 19:21
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 First shipped in 1.3.0 labels Mar 12, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.3.0 First shipped in 1.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants