Sort table columns alphabetically in sql editor left bar#1464
Closed
vera-liu wants to merge 2 commits into
Closed
Conversation
Member
|
Oh I just saw this after I landed a similar PR I wrote in the train, I didn't mean to "take over", sorry about that. I think the default column order is better default than an alphabetical sort as a default since many people are careful when defining the column ordering (pk fields first, name, description, ..., audit fields last, ...). |
|
it would be great if we posted on the issue when we are starting work and/or check if there is someone assigned already, so we don't work over each other in the future. nice that this was just a small change, so nbd :) |
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
This was referenced Dec 13, 2021
Open
This was referenced Apr 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request: #1444
Done: Added sorting in render() of TableElement, table columns are sort by names in SqlEditorLeft now
Before:
After:
needs-review @mistercrunch