fix(examples): calendar chart metric should be metrics#15173
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15173 +/- ##
==========================================
- Coverage 77.16% 77.09% -0.08%
==========================================
Files 971 971
Lines 50243 50243
Branches 6112 6112
==========================================
- Hits 38772 38736 -36
- Misses 11268 11304 +36
Partials 203 203
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/testenv up |
|
@rusackas Ephemeral environment spinning up at http://54.212.78.129:8080. Credentials are |
rusackas
left a comment
There was a problem hiding this comment.
Not sure why the presto/hive CI action keeps failing, but the code LGTM and it sure seems to have fixed the problem in manual testing!
|
I've restarted the presto/hive tests a third time now. If it doesn't pass, it doesn't seem like flakiness. The error doesn't look like it has anything to do with this PR though. |
|
You might need to rebase this to bring in #15163 to fix the Presto/Hive tests |
ed8868b to
7902592
Compare
7902592 to
e0367fe
Compare
|
Ephemeral environment shutdown and build artifacts deleted. |
* fix(examples): calendar chart metric should be metrics * fix presto test
* fix(examples): calendar chart metric should be metrics * fix presto test
* fix(examples): calendar chart metric should be metrics * fix presto test
* fix(examples): calendar chart metric should be metrics * fix presto test
SUMMARY
One of the example calendar heatmap charts has incorrectly defined the
metriccontrol value, while it really should bemetrics(the value should also be an array of strings, not a string).BEFORE
AFTER
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION