fix: trim string value of spaces in listview search#15175
Merged
Conversation
Member
|
this approach works, but wondering if we should add it to api since it seems like this could come up in other api calls |
Member
Author
suddjian
approved these changes
Jun 15, 2021
Codecov Report
@@ Coverage Diff @@
## master #15175 +/- ##
==========================================
- Coverage 77.41% 77.41% -0.01%
==========================================
Files 969 969
Lines 49918 50000 +82
Branches 6393 6431 +38
==========================================
+ Hits 38645 38705 +60
- Misses 11070 11092 +22
Partials 203 203
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nytai
approved these changes
Jun 15, 2021
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This pr fixes an issue with the listview search were if a space was either at the front or end of the string it would not return any results.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before:
https://user-images.githubusercontent.com/17326228/122089466-a540d500-cdbb-11eb-811f-1b442e0dd5cb.mov
after:
Screen.Recording.2021-06-15.at.9.29.28.AM.mov
TESTING INSTRUCTIONS
Go to listviews and try searching with spaces in string
ADDITIONAL INFORMATION