feat(api): add featured datatypes to dashboard dataset ep#15188
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15188 +/- ##
=======================================
Coverage 77.40% 77.40%
=======================================
Files 969 969
Lines 50021 50031 +10
Branches 6432 6432
=======================================
+ Hits 38717 38727 +10
Misses 11099 11099
Partials 205 205
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Merged
8 tasks
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
To be able to filter out unnecessary filter types on the native filters config form (primarily temporal filters, but potentially others later), we need to know what types of datatypes are available on the datasets that are referenced on the dashboard. While we recently added the
type_genericfield to the column object (see #14863) and could iterate through all columns to check if they are temporal or not, the list of columns that are returned by the response fromapi/v1/dashboard/<pk>/datasetshave been pre-filtered to contain only a subset of the actually featured columns. Therefore, we either need to return the full list of columns in the response, or add a new field that contains a list of datatypes featured in the dataset columns. To avoid bloating the response payload, this PR proposes adding the latter, i.e. a new fieldcolumn_typesto the response, that contains a list of allGenericDataTypes that are featured in the dataset columns.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
With this change, a new property

column_typesis available on Redux:TESTING INSTRUCTIONS
CI + updated test
ADDITIONAL INFORMATION