Skip to content

fix: Update Invalid Port SIP-40 Reference #15464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hughhhh merged 3 commits into from
Jun 29, 2021
Merged

fix: Update Invalid Port SIP-40 Reference #15464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88655a6
change reference for invalid port to 1031
hughhhh Jun 29, 2021
69c70d4
fix test
hughhhh Jun 29, 2021
981646d
Merge branch 'pexdax/db-connection-ui' of https://github.com/apache/s…
hughhhh Jun 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/src/pages/docs/Miscellaneous/issue_codes.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,3 +271,11 @@ One or more parameters specified in the query are malformatted.
```

The query contains one or more malformed template parameters. Please check your query and confirm that all template parameters are surround by double braces, for example, "{{ ds }}". Then, try running your query again.

## Issue 1031

```
The database port provided is invalid.
```

Please check that the provided database port is an integer between 0 and 65535 (inclusive).
2 changes: 1 addition & 1 deletion superset/errors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ class SupersetErrorType(str, Enum):
{"code": 1008, "message": _("Issue 1008 - The port is closed.")},
],
SupersetErrorType.CONNECTION_INVALID_PORT_ERROR: [
{"code": 1021, "message": _("Issue 1021 - Port number is invalid.")},
{"code": 1031, "message": _("Issue 1031 - Port number is invalid.")},
],
SupersetErrorType.CONNECTION_HOST_DOWN_ERROR: [
{
Expand Down
12 changes: 6 additions & 6 deletions tests/databases/api_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1818,8 +1818,8 @@ def test_validate_parameters_invalid_port(self):
"invalid": ["port"],
"issue_codes": [
{
"code": 1021,
"message": "Issue 1021 - Port number is invalid.",
"code": 1031,
"message": "Issue 1031 - Port number is invalid.",
}
],
},
Expand All @@ -1832,8 +1832,8 @@ def test_validate_parameters_invalid_port(self):
"invalid": ["port"],
"issue_codes": [
{
"code": 1021,
"message": "Issue 1021 - Port number is invalid.",
"code": 1031,
"message": "Issue 1031 - Port number is invalid.",
}
],
},
Expand Down Expand Up @@ -1948,8 +1948,8 @@ def test_validate_parameters_invalid_port_range(self, is_hostname_valid):
"invalid": ["port"],
"issue_codes": [
{
"code": 1021,
"message": "Issue 1021 - Port number is invalid.",
"code": 1031,
"message": "Issue 1031 - Port number is invalid.",
}
],
},
Expand Down