feat: use new API endpoint to build CSV reports#15830
Merged
betodealmeida merged 2 commits intoJul 22, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15830 +/- ##
=======================================
Coverage 76.90% 76.90%
=======================================
Files 984 984
Lines 51705 51705
Branches 6995 6995
=======================================
Hits 39764 39764
Misses 11717 11717
Partials 224 224
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
8 tasks
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* feat: add `GET /api/v1/chart/{chart_id}/data/?format{format}` API
* feat: use new API endpoint to build CSV reports
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* feat: add `GET /api/v1/chart/{chart_id}/data/?format{format}` API
* feat: use new API endpoint to build CSV reports
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* feat: add `GET /api/v1/chart/{chart_id}/data/?format{format}` API
* feat: use new API endpoint to build CSV reports
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
* feat: add `GET /api/v1/chart/{chart_id}/data/?format{format}` API
* feat: use new API endpoint to build CSV reports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR changes the reports executor to use the new CSV endpoint introduced in #15827. This allows us to produce CSV reports from visualization types not defined in
viz.py, like pie charts and the new pivot table.Before the executor was using the
explore_jsonendpoint, which is not supported for the new visualization types.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION