fix: Update Query Context on Explore loading#15865
Merged
Merged
Conversation
hughhhh
force-pushed
the
hugh/update-put-query-context
branch
from
e33f108 to
a002bdd
Compare
…/update-put-query-context
Codecov Report
@@ Coverage Diff @@
## master #15865 +/- ##
==========================================
- Coverage 77.02% 76.97% -0.06%
==========================================
Files 985 986 +1
Lines 51850 52683 +833
Branches 7068 7184 +116
==========================================
+ Hits 39939 40552 +613
- Misses 11686 11903 +217
- Partials 225 228 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
betodealmeida
approved these changes
Jul 26, 2021
Member
betodealmeida
left a comment
betodealmeida
left a comment
There was a problem hiding this comment.
Looks great, I just left a comment on a line that should be deleted.
8 tasks
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* create serialize json function * saving for now * saving for now * lint * cleanup * fix network request * update test * Update tests/integration_tests/charts/api_tests.py Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* create serialize json function * saving for now * saving for now * lint * cleanup * fix network request * update test * Update tests/integration_tests/charts/api_tests.py Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* create serialize json function * saving for now * saving for now * lint * cleanup * fix network request * update test * Update tests/integration_tests/charts/api_tests.py Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
9 tasks
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* create serialize json function * saving for now * saving for now * lint * cleanup * fix network request * update test * Update tests/integration_tests/charts/api_tests.py Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
mistercrunch
added
the
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
* create serialize json function * saving for now * saving for now * lint * cleanup * fix network request * update test * Update tests/integration_tests/charts/api_tests.py Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
With the new reports and alerts updates, we need to be able to set the query context on the frontend to be able to pull the data properly for emails. To do this we are adding an additional
PUTcall on all explore loads to make sure theChartresource is up to date and allow us to generate a report.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION