feat: auto sync table columns when change dataset#15887
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15887 +/- ##
==========================================
- Coverage 77.03% 76.80% -0.24%
==========================================
Files 989 990 +1
Lines 52410 52455 +45
Branches 6634 6637 +3
==========================================
- Hits 40376 40289 -87
- Misses 11811 11942 +131
- Partials 223 224 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
91df1ff to
fc58318
Compare
|
/testenv up |
|
@junlincc Ephemeral environment spinning up at http://34.220.44.34:8080. Credentials are |
fc58318 to
95b871b
Compare
villebro
left a comment
There was a problem hiding this comment.
Thanks for the fix and the general cleanup! I almost think we shouldn't be able to change the dataset when inside the modal (if the user wants to change dataset, they should probably close the modal and then change the dataset and reopen the modal). However, this change can be postponed to later after proper discussion about the UX has been done.
|
Ephemeral environment shutdown and build artifacts deleted. |
* feat: auto sync dataset metadata when change dataset * diablo sync button when edit mode * handle undefine schema * fix py UT * fix FE UT * improve test coverage * fix UT
* feat: auto sync dataset metadata when change dataset * diablo sync button when edit mode * handle undefine schema * fix py UT * fix FE UT * improve test coverage * fix UT
* feat: auto sync dataset metadata when change dataset * diablo sync button when edit mode * handle undefine schema * fix py UT * fix FE UT * improve test coverage * fix UT
* feat: auto sync dataset metadata when change dataset * diablo sync button when edit mode * handle undefine schema * fix py UT * fix FE UT * improve test coverage * fix UT
* feat: auto sync dataset metadata when change dataset * diablo sync button when edit mode * handle undefine schema * fix py UT * fix FE UT * improve test coverage * fix UT
SUMMARY
Currently, Superset is unable to auto sync table columns when changing dataset "pointer/reference". This issue introduces a new API to support.
Limitation:
Currently, the dataset system is unable to save duplicated datasets (database/schema/table all the same). If "re-pointer" an existing dataset, the database will return an integrity error. I will fix it in separate PR.
UI Change:
Not allowed to click
sync columns from sourcewhen dataset in EDIT mode. The system will automatically complete the sync.closes: #15789
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After
autosync_conversion.mp4
TESTING INSTRUCTIONS
edit datasetmodal in dataset listphysical tableorvirtual table), schema, databaseADDITIONAL INFORMATION