feat: improve embedded data table in text reports#16335
Merged
Conversation
eschutho
approved these changes
Aug 18, 2021
Codecov Report
@@ Coverage Diff @@
## master #16335 +/- ##
==========================================
- Coverage 76.65% 76.37% -0.28%
==========================================
Files 999 1000 +1
Lines 53394 53458 +64
Branches 6817 6817
==========================================
- Hits 40929 40831 -98
- Misses 12228 12390 +162
Partials 237 237
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
betodealmeida
added a commit
to preset-io/superset
that referenced
this pull request
Aug 19, 2021
* feat: improve HTML table in text reports * Remove unused import * Update tests * Fix test
9 tasks
Contributor
|
🏷 2021.31 |
henryyeh
pushed a commit
to preset-io/superset
that referenced
this pull request
Aug 19, 2021
* feat: improve HTML table in text reports * Remove unused import * Update tests * Fix test (cherry picked from commit afb8bd5)
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* feat: improve HTML table in text reports * Remove unused import * Update tests * Fix test
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
* feat: improve HTML table in text reports * Remove unused import * Update tests * Fix test
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
* feat: improve HTML table in text reports * Remove unused import * Update tests * Fix test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR improves the data table that is embedded in the email/slack notifications as text for reports.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
Create a report as "text" and send to email.
ADDITIONAL INFORMATION