chore: bump emotion to help with cache clobbering by eschutho · Pull Request #16559 · apache/superset

eschutho · 2021-09-01T23:01:14Z

SUMMARY

we were seeing some instances where emotion styling wasn't showing up on sql lab. I think it may be related to this issue: emotion-js/emotion#2209 so I bumped emotion to bring in the patch fix. So far testing looks positive that it fixed the issue.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Reload sql lab often- each load should have all the styles.

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

codecov · 2021-09-01T23:20:42Z

Codecov Report

Merging #16559 (658c1a9) into master (02798a3) will increase coverage by 0.52%.
The diff coverage is n/a.

❗ Current head 658c1a9 differs from pull request most recent head 5431f4b. Consider uploading reports for the commit 5431f4b to get more accurate results

@@            Coverage Diff             @@
##           master   #16559      +/-   ##
==========================================
+ Coverage   76.19%   76.71%   +0.52%     
==========================================
  Files        1002     1002              
  Lines       53813    53801      -12     
  Branches     7287     6858     -429     
==========================================
+ Hits        41005    41276     +271     
+ Misses      12568    12288     -280     
+ Partials      240      237       -3

Flag	Coverage Δ
javascript	`71.00% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/db_engines/hive.py	`82.14% <0.00%> (-3.05%)`	⬇️
superset-frontend/src/views/CRUD/hooks.ts	`46.98% <0.00%> (ø)`
...end/src/SqlLab/components/RunQueryActionButton.tsx	`65.11% <0.00%> (ø)`
...end/src/visualizations/FilterBox/transformProps.ts	`6.66% <0.00%> (ø)`
superset/views/base_api.py	`98.31% <0.00%> (+0.42%)`	⬆️
superset/utils/core.py	`89.89% <0.00%> (+0.48%)`	⬆️
superset/security/manager.py	`91.84% <0.00%> (+0.52%)`	⬆️
superset/db_engine_specs/postgres.py	`97.36% <0.00%> (+0.87%)`	⬆️
superset/utils/cache.py	`74.52% <0.00%> (+0.94%)`	⬆️
superset-frontend/src/components/Select/Select.tsx	`73.42% <0.00%> (+0.96%)`	⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02798a3...5431f4b. Read the comment docs.

villebro

You appear to be on an old version of npm (lock file version is downgraded from 2 to 1 in this PR). Can you make sure you're running npm i on a npm version 7?

eschutho · 2021-09-02T17:58:34Z

You appear to be on an old version of npm (lock file version is downgraded from 2 to 1 in this PR). Can you make sure you're running npm i on a npm version 7?

Thanks for catching that @villebro!

villebro

LGTM!

* add support for adhoc columns to api and sqla model * fix some types * fix duplicates in column names * fix more lint * fix schema and dedup * clean up some logic * first pass at fixing viz.py * Add frontend support for adhoc columns * Add title edit * Fix showing custom title * Use column name as default value in sql editor * fix: Adds a loading message when needed in the Select component (#16531) * fix(tests): make parquet select deterministic with order by (#16570) * bump emotion to help with cache clobbering (#16559) * fix: Support Jinja template functions in global async queries (#16412) * Support Jinja template functions in async queries * Pylint * Add tests for async tasks * Remove redundant has_request_context check * fix: impersonate user label/tooltip (#16573) * docs: update for small typos (#16568) * feat: Add Aurora Data API engine spec (#16535) * feat: Add Aurora Data API engine spec * Fix lint * refactor: sql_json view endpoint: encapsulate ctas parameters (#16548) * refactor sql_json view endpoint: encapsulate ctas parameters * fix failed tests * fix failed tests and ci issues * refactor sql_json view endpoint: separate concern into ad hod method (#16595) * feat: Experimental cross-filter plugins (#16594) * fix:fix get permission function * feat: add cross filter chart in charts gallery under FF * chore(deps): bump superset-ui to 0.18.2 (#16601) * update type guard references * fix imports * update series_columns schema * Add changes that got lost in rebase * Use current columns name or expression as sql editor init value * add integration test and do minor fixes * Bump superset-ui * fix linting issue * bump superset-ui to 0.18.22 * resolve merge conflict * lint * fix select filter infinite loop * bump superset-ui to 0.18.23 * Fix auto setting column popover title * Enable adhoc columns only if UX_BETA enabled * put back removed test * Move popover height and width to constants * Refactor big ternary expression Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> Co-authored-by: Rob DiCiuccio <rob.diciuccio@gmail.com> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: joeADSP <75027008+joeADSP@users.noreply.github.com> Co-authored-by: ofekisr <35701650+ofekisr@users.noreply.github.com> Co-authored-by: simcha90 <56388545+simcha90@users.noreply.github.com>

* add support for adhoc columns to api and sqla model * fix some types * fix duplicates in column names * fix more lint * fix schema and dedup * clean up some logic * first pass at fixing viz.py * Add frontend support for adhoc columns * Add title edit * Fix showing custom title * Use column name as default value in sql editor * fix: Adds a loading message when needed in the Select component (apache#16531) * fix(tests): make parquet select deterministic with order by (apache#16570) * bump emotion to help with cache clobbering (apache#16559) * fix: Support Jinja template functions in global async queries (apache#16412) * Support Jinja template functions in async queries * Pylint * Add tests for async tasks * Remove redundant has_request_context check * fix: impersonate user label/tooltip (apache#16573) * docs: update for small typos (apache#16568) * feat: Add Aurora Data API engine spec (apache#16535) * feat: Add Aurora Data API engine spec * Fix lint * refactor: sql_json view endpoint: encapsulate ctas parameters (apache#16548) * refactor sql_json view endpoint: encapsulate ctas parameters * fix failed tests * fix failed tests and ci issues * refactor sql_json view endpoint: separate concern into ad hod method (apache#16595) * feat: Experimental cross-filter plugins (apache#16594) * fix:fix get permission function * feat: add cross filter chart in charts gallery under FF * chore(deps): bump superset-ui to 0.18.2 (apache#16601) * update type guard references * fix imports * update series_columns schema * Add changes that got lost in rebase * Use current columns name or expression as sql editor init value * add integration test and do minor fixes * Bump superset-ui * fix linting issue * bump superset-ui to 0.18.22 * resolve merge conflict * lint * fix select filter infinite loop * bump superset-ui to 0.18.23 * Fix auto setting column popover title * Enable adhoc columns only if UX_BETA enabled * put back removed test * Move popover height and width to constants * Refactor big ternary expression Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> Co-authored-by: Rob DiCiuccio <rob.diciuccio@gmail.com> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: joeADSP <75027008+joeADSP@users.noreply.github.com> Co-authored-by: ofekisr <35701650+ofekisr@users.noreply.github.com> Co-authored-by: simcha90 <56388545+simcha90@users.noreply.github.com>

superset-github-bot Bot added the preset-io label Sep 1, 2021

pull-request-size Bot added the size/XS label Sep 1, 2021

betodealmeida approved these changes Sep 2, 2021

View reviewed changes

villebro requested changes Sep 2, 2021

View reviewed changes

bump emotion to help with cache clobbering

5431f4b

eschutho force-pushed the elizabeth/bump-emotion branch from 0854a41 to 5431f4b Compare September 2, 2021 17:48

villebro approved these changes Sep 2, 2021

View reviewed changes

eschutho merged commit a0db536 into apache:master Sep 2, 2021

eschutho deleted the elizabeth/bump-emotion branch September 2, 2021 20:48

villebro mentioned this pull request Sep 6, 2021

chore(core): move @emotion/styled to peer dependency apache-superset/superset-ui#1347

Merged

villebro pushed a commit to preset-io/superset that referenced this pull request Sep 6, 2021

bump emotion to help with cache clobbering (apache#16559)

793c027

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021

bump emotion to help with cache clobbering (apache#16559)

407d0ab

QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021

bump emotion to help with cache clobbering (apache#16559)

a90617f

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 First shipped in 1.4.0 labels Mar 13, 2024

qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026

bump emotion to help with cache clobbering (apache#16559)

03d5c1d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: bump emotion to help with cache clobbering#16559

chore: bump emotion to help with cache clobbering#16559
eschutho merged 1 commit into
apache:masterfrom
preset-io:elizabeth/bump-emotion

eschutho commented Sep 1, 2021

Uh oh!

codecov Bot commented Sep 1, 2021 •

edited

Loading

Uh oh!

villebro left a comment

Uh oh!

eschutho commented Sep 2, 2021

Uh oh!

villebro left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

eschutho commented Sep 1, 2021

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

codecov Bot commented Sep 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

villebro left a comment

Choose a reason for hiding this comment

Uh oh!

eschutho commented Sep 2, 2021

Uh oh!

villebro left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Sep 1, 2021 •

edited

Loading