Skip to content

feat: Tabs in column#16593

Merged
amitmiran137 merged 24 commits into
apache:masterfrom
simcha90:tabs_in_column
Sep 13, 2021
Merged

feat: Tabs in column#16593
amitmiran137 merged 24 commits into
apache:masterfrom
simcha90:tabs_in_column

Conversation

@simcha90
Copy link
Copy Markdown
Contributor

@simcha90 simcha90 commented Sep 5, 2021

SUMMARY

This PR add possibility to add Tabs layout element to Column tab element

Screen.Recording.2021-09-05.at.0.17.26.mov

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@simcha90 simcha90 closed this Sep 5, 2021
@simcha90 simcha90 reopened this Sep 5, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 5, 2021

Codecov Report

Merging #16593 (3956885) into master (d25b096) will increase coverage by 0.12%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16593      +/-   ##
==========================================
+ Coverage   76.71%   76.83%   +0.12%     
==========================================
  Files        1002     1004       +2     
  Lines       53780    53902     +122     
  Branches     6859     7339     +480     
==========================================
+ Hits        41255    41416     +161     
+ Misses      12288    12246      -42     
- Partials      237      240       +3     
Flag Coverage Δ
javascript 71.28% <88.88%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/dashboard/components/gridComponents/Column.jsx 87.87% <ø> (ø)
...nd/src/dashboard/components/gridComponents/Row.jsx 86.66% <ø> (ø)
...perset-frontend/src/dashboard/util/isValidChild.ts 85.71% <ø> (-0.96%) ⬇️
...ashboard/components/gridComponents/ChartHolder.jsx 69.81% <87.50%> (+0.50%) ⬆️
...nd/src/dashboard/containers/DashboardComponent.jsx 100.00% <100.00%> (ø)
...mponents/nativeFilters/FiltersConfigModal/utils.ts 72.22% <0.00%> (-1.39%) ⬇️
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 94.31% <0.00%> (-1.14%) ⬇️
superset-frontend/src/dashboard/actions/hydrate.js 1.69% <0.00%> (-0.03%) ⬇️
superset-frontend/src/views/CRUD/hooks.ts 46.98% <0.00%> (ø)
superset-frontend/src/SqlLab/actions/sqlLab.js 59.01% <0.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d25b096...3956885. Read the comment docs.

Copy link
Copy Markdown
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am looking forward to the feature.

Tested in the local environment

  1. can't change all of tab title
  2. can't close the delete modal
    https://user-images.githubusercontent.com/2016594/132463507-6626b7dc-b9b3-49bb-b301-8d1216343455.mov

@simcha90
Copy link
Copy Markdown
Contributor Author

@zhaoyongjie thanks for review I fixed bugs that you found :)

@zhaoyongjie zhaoyongjie self-requested a review September 13, 2021 04:34
Copy link
Copy Markdown
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in my local environment and codes LGTM. I am looking forward to this feature.

@amitmiran137 amitmiran137 merged commit 668ae23 into apache:master Sep 13, 2021
@amitmiran137 amitmiran137 deleted the tabs_in_column branch September 13, 2021 15:09
@junlincc
Copy link
Copy Markdown
Member

Thanks for the contribution! we should have it highlighted in next release

@villebro villebro removed the v1.3 label Oct 4, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* fix:fix get permission function

* feat: add tabs inside column

* lint: fix lint

* test: fix test

* test: fix tests

* test: fix tests

* fix: pass onChangeTab function through layout
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
* fix:fix get permission function

* feat: add tabs inside column

* lint: fix lint

* test: fix test

* test: fix tests

* test: fix tests

* fix: pass onChangeTab function through layout
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 First shipped in 1.4.0 labels Mar 13, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
* fix:fix get permission function

* feat: add tabs inside column

* lint: fix lint

* test: fix test

* test: fix tests

* test: fix tests

* fix: pass onChangeTab function through layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.4.0 First shipped in 1.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants