refactor: sql_json view endpoint: separate save query concern#16646
Merged
Conversation
ofekisr
force-pushed
the
refactor/sql_json_view6
branch
from
eb2d2ec to
c569a3f
Compare
Codecov Report
@@ Coverage Diff @@
## master #16646 +/- ##
==========================================
- Coverage 76.70% 76.56% -0.15%
==========================================
Files 1004 1004
Lines 53983 53983
Branches 7335 7335
==========================================
- Hits 41408 41332 -76
- Misses 12336 12412 +76
Partials 239 239
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
amitmiran137
approved these changes
Sep 9, 2021
Member
amitmiran137
left a comment
amitmiran137
left a comment
There was a problem hiding this comment.
Simple method extraction
LGTM!
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
The sql_json view code in superset core view without any "clean code" standard and it does not adopt any software development principle.
This is the sixth PR in the sequence of future PRs (previous PR) try to solve it by refactoring the code.
The PR focus of separate "save new query" concern into ad hod method so the code will be cleaner
there are no logic changes so it implies on the current tests.