feat(jinja): improve url parameter formatting#16711
Merged
Merged
Conversation
f94cdfa to
c7fbe85
Compare
Codecov Report
@@ Coverage Diff @@
## master #16711 +/- ##
==========================================
- Coverage 76.93% 76.73% -0.20%
==========================================
Files 1007 1007
Lines 54146 54152 +6
Branches 7369 7369
==========================================
- Hits 41655 41552 -103
- Misses 12251 12360 +109
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
340d87d to
5be48ce
Compare
ktmud
approved these changes
Sep 15, 2021
stevenuray
pushed a commit
to preset-io/superset
that referenced
this pull request
Sep 17, 2021
* feat(jinja): improve url parameter formatting * add UPDATING.md * fix test (cherry picked from commit 88c09c2)
villebro
added a commit
that referenced
this pull request
Sep 22, 2021
* feat(jinja): improve url parameter formatting * add UPDATING.md * fix test
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* feat(jinja): improve url parameter formatting * add UPDATING.md * fix test
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
* feat(jinja): improve url parameter formatting * add UPDATING.md * fix test
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
* feat(jinja): improve url parameter formatting * add UPDATING.md * fix test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add handling of special characters to URL param function in Jinja context to improve cross-database filter clause compatibility. This is done by adding the parameter
escape_resultto theurl_paramfunction which defaults toTrue. When enabled, it escapes the value of the requested url param using the relevant SQLAlchemy dialect for the selected database.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION