fix(query_object): missing series validation not raised an exception#16946
Merged
amitmiran137 merged 1 commit intoOct 3, 2021
Merged
Conversation
9 tasks
24d0e3a to
581a206
Compare
Codecov Report
@@ Coverage Diff @@
## master #16946 +/- ##
==========================================
- Coverage 76.98% 76.90% -0.08%
==========================================
Files 1028 1028
Lines 55065 55071 +6
Branches 7486 7486
==========================================
- Hits 42390 42351 -39
- Misses 12427 12472 +45
Partials 248 248
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Member
|
LGTM, thanks for fixing my oversight @ofekisr ! Good example of the benefits of having good code coverage (I'll try to add a quick test for that) |
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the PR feat: add support for generic series limit
take a look at query_object file, line 280, an exception is not raised when there are missing series